On Sun, Sep 18, 2022 at 08:27:53PM +0200, Johannes Schauer Marin Rodrigues 
wrote:
> Hi,
> 
> Quoting Julian Gilbey (2022-09-18 18:54:10)
> > On Wed, Sep 14, 2022 at 08:13:08AM +0200, Johannes Schauer Marin Rodrigues
> > wrote:
> > > Hi,
> > > > [...]
> > > > The same applies for all of the autopkgtest related options, such as
> > > > --autopkgtest-virt-server-opt.
> > > 
> > > which options are different if you are building for a stable update?
> > 
> > I have in my .sbuildrc:
> > 
> > $autopkgtest_opts = ['--apt-upgrade', '--', 'lxc', '-s', 
> > 'autopkgtest-testing'];
> > [...]
> 
> did you try putting the following into your ~/.sbuildrc:
> 
> $autopkgtest_opts = ['--apt-upgrade', '--', 'lxc', '-s', 'autopkgtest-%r'];

That's a good point; I hadn't spotted that substitution variable.

> > But in general, the idea that it is impossible to override settings from a
> > configuration file seems an unfortunate design choice.
> 
> That is correct. But letting sbuild run autopkgtest is also a bad design
> choice. Since the $autopkgtest_opts are a list of options, it would also be 
> bad
> to let the command line options just replace what was already set. So then you
> need some sort of interface that lets you add or remove arbitrary stuff. This
> can become very complicated very fast. We can also not change this now because
> sbuild is also heavily used from scripts that now rely on the existing
> functionality.

Another good point (about the bad design).  I wasn't suggesting
changing the existing behaviour for exactly the reason you indicate,
rather I was suggesting a new option to mean "clear all existing
$autopkgtest_opts and start with an empty list".  But that also feels
a bit clunky.

> [...]
> If you want to do more complex stuff, consider using the SBUILD_CONFIG
> environment variable.

That would work too.

Best wishes,

   Julian

Reply via email to