On 29/08/2022 16:46, Jonas Smedegaard wrote:
Quoting Yadd (2022-08-25 20:38:08)
could you also push node-rollup-plugin-terser ? I fixed it for terser >=
5 (partial patch revert: 2001_*) and added a "Breaks
node-rollup-plugin-terser (<< 7.0.2+~5.0.1-3~)" in node-terser.

Thanks for looking into this.  I am not happy with current state of
node-rollup-plugin-terser, however:

a) Why is patch 2001 still needed?  You kept parts of if despite terser
now being v5.  Yes, testsuite fails without that patch but I don't
understand why (suspect the cause being newer-than-expected jest).

Hi,

yes this patch should be renamed. The part I kept wasn't related to terser 5 but something else. This seems not be related to jest (existed before jest update). I'll search from where comes this error

b) Why do binary packages now contain file
/usr/share/nodejs/*/pkgjs-lock.json? Bug in pkg-js-tools, perhaps?

This files are automatically added to all package suspected to embed copies of some other modules (ie built using webpack or rollup). We discussed about that some months ago, it may help in case of CVE

c) Why do testsuite for ascjs emit several errors without failing?
Bug in pkg-js-tools, perhaps?

Here:
  + node Xascjs/test.js
  ascjs v5.0.1 - 33 tests

true both import and export can be overwritten

The test is launched using "set -e", so if test succeeds, it means that both `node Xascjs/test.js` and
`jest --ci --testTimeout 60000 test/test.js` succeeds (ie returned 0)

Cheers,
Yadd

Reply via email to