Control: tag -1 + pending
22.08.2022 17:11, L. van Belle wrote:
I can confirm the patch works.
I've tested on a Debian Bullseye build with
cifs-utils 7.0 from https://ftp.samba.org/pub/linux-cifs/cifs-utils/
I refreshed patch 001.
Added the patch shown buy Helmut.
And I builded against Debian Bullseye with parallel=7 and parallel=1
Here's the upstream commit which fixes the problem:
commit aeaa786aceb0ea781ded2c151fb68f6b34880ad4
Author: lizhe <lizh...@huawei.com>
Date: Tue May 26 11:54:11 2020 +0800
cifs-utils: fix probabilistic compiling error
When we compile cifs-utils, we may probabilistic
encounter install error like:
cd ***/sbin && ln -sf mount.cifs mount.smb3
***/sbin: No such file or directory
The reason of this problem is that if we compile
cifs-utils using multithreading, target
'install-sbinPROGRAMS' may be built after
target 'install-exec-hook' of the main Makefile.
Target 'install-sbinPROGRAMS' will copy the
executable file 'mount.cifs' to the $(ROOTSBINDIR),
which target 'install-exec-hook' will do the
'ln' command on.
This patch add the dependency of target
'install-exec-hook' to ensure the correct order
of the compiling.
Signed-off-by: lizhe <lizh...@huawei.com>
diff --git a/Makefile.am b/Makefile.am
index a95782d..8a17e73 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -117,7 +117,7 @@ endif
SUBDIRS = contrib
-install-exec-hook:
+install-exec-hook: install-sbinPROGRAMS
(cd $(DESTDIR)$(ROOTSBINDIR) && ln -sf mount.cifs mount.smb3)
install-data-hook:
I think both are wrong but both do the job.
Now, the question is: do we need to fix this for bullseye?
It smells like there's no need to, no?
Thanks,
/mjt
