Package: adduser
Version: 3.127
Severity: minor

Hey.

The following is rather just cosmetics...

The new adduser.conf says:
# A commented out setting indicates that this is the default in the
# code. If you need to change those settings, remove the comment and
# make your intended change.


IMO that system of documenting defaults is generally unfortunate.

What may easily happen is, that people follow that advise but later
comment some value again without setting it back to the original
value (which, when commented, is - as per documentation above -
ought to be the default).


This can easily cause confusion on what's *actually* the default,
especially when multiple admins work on the system.



Perhaps it would be better to either include the defaults as written
comments as in:
# The DHOME variable specifies the directory containing users' home
# directories.
# Default: /home
#DHOME=/home

or not include the defaults in the actual conffile at all but just
in the manpage (IMO better, since that cannot (easily) be changed and
will always be up-to-date).

Same could btw. be done for the in-conffile documentation. Kinda overlaps
with the manpage, an just makes handling the file on upgrades
trickier.


Cheers,
Chris.

Reply via email to