On Sun, May 07, 2006 at 06:07:19PM +0700, Theppitak Karoonboonyanan <[EMAIL PROTECTED]> wrote: > On 5/7/06, Mike Hommey <[EMAIL PROTECTED]> wrote: > > > >I'm afraid I'm not going to consider this patch. And probably upstream > >won't like it either. You should link against libthai, not dynamically > >load it. That probably means you have to make a component out of your > >linebreaker if you don't want the whole firefox to depend on it. > > Well, I have no choice. As mentioned in comment #50 in upstream > bug, even creating an alternative line breaker engine is impossible, > not to mention other kind of refactoring. > > So, unless we want to make big changes in upstream source > to make line breaker engine replacement possible, another > choice seems to be having firefox link with and depend on libthai. > > If that's acceptable, I certainly can rework the patch.
You can pretty much easily put your nsLibThaiLineBreaker in a component. You can take a look at how the native uconv support works (intl/src and intl/native) for an example of how to do that. Comment #41 in upstream bug describes something along these lines, except it's talking about ICU instead of libthai. Mike -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
