Source: multipath-tools Version: 0.9.0-3 Severity: wishlist Tags: patch User: reproducible-bui...@lists.alioth.debian.org Usertags: timestamps X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org
Hi, Whilst working on the Reproducible Builds effort [0] we noticed that multipath-tools could not be built reproducibly. Whilst the package is very careful to export KBUILD_BUILD_TIMESTAMP based on the value of SOURCE_DATE_EPOCH, the issue is that the Makefile under libdmmp/ overrides that. Patch attached. [0] https://reproducible-builds.org/ Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
--- a/debian/patches/0012-Reproducible-build.patch 1969-12-31 16:00:00.000000000 -0800 --- b/debian/patches/0012-Reproducible-build.patch 2022-08-03 07:52:00.661589713 -0700 @@ -0,0 +1,15 @@ +Description: Make the build reproducible +Author: Chris Lamb <la...@debian.org> +Last-Update: 2022-08-03 + +--- multipath-tools-0.9.0.orig/libdmmp/Makefile ++++ multipath-tools-0.9.0/libdmmp/Makefile +@@ -75,7 +75,7 @@ docs/man/dmmp_strerror.3: $(HEADERS) + TEMPFILE=$(shell mktemp); \ + cat $^ | perl docs/doc-preclean.pl >$$TEMPFILE; \ + LC_ALL=C \ +- KBUILD_BUILD_TIMESTAMP=`git log -n1 --pretty=%cd --date=iso -- $^` \ ++ KBUILD_BUILD_TIMESTAMP=`echo $$KBUILD_BUILD_TIMESTAMP | grep . || git log -n1 --pretty=%cd --date=iso -- $^` \ + perl docs/kernel-doc -man $$TEMPFILE | \ + perl docs/split-man.pl docs/man; \ + rm -f $$TEMPFILE --- a/debian/patches/series 2022-08-03 07:48:33.457362430 -0700 --- b/debian/patches/series 2022-08-03 07:51:56.085584559 -0700 @@ -7,3 +7,4 @@ 0009-kpartx-rules-use-Debian-specific-partx-path.patch 0010-multipath.rules-do-not-assume-usrmerged-paths.patch 0011-Fix-bashism-in-kpartx_id-script.patch +0012-Reproducible-build.patch
