Control: clone -1 -2
Control: reassign -2 init-system-helpers
Control: retitle -2 deb-systemd-helper fails with circular Also=
Control: found -2 1.63
Control: severity -1 serious
Control: tags -1 + patch

Am 30.06.22 um 14:26 schrieb Michael Biebl:
This might be a bug in i-s-h, but filing against systemd-homed for
now.

systemd-homed.service:
[Install]
WantedBy=multi-user.target
Alias=dbus-org.freedesktop.home1.service
Also=systemd-homed-activate.service systemd-userdbd.service

systemd-homed-activate.service:
[Install]
WantedBy=systemd-homed.service
Also=systemd-homed.service

→ we have a circular dependency here, maybe deb-systemd-helper get's
confused by that


I just checked that we can mitigate this issue by removing this circular Also= dependency. It is indeed deb-systemd-helper getting confused by that and as a result not writing proper state files to /var/lib/systemd/deb-systemd-helper.
So the damage is already done during installation in postinst.
Thus raising to RC to warn users from installing systemd-homed atm.

I propose a patch like the attached one, i.e. dropping the Also= from systemd-homed-active.service. WDYT?

I've also cloned the issue for i-s-h, as we might want to fix that properly. My perl is a bit rusty, so would appreciate help with that.

@bluca: do you think the attached patch is suitable for upstream?

I find this circular Also= dependency kinda odd, I have to admit.

Regards,
Michael
From 163c68923c919394b77e73f0c6ae3c6193c8a46f Mon Sep 17 00:00:00 2001
From: Michael Biebl <bi...@debian.org>
Date: Thu, 30 Jun 2022 14:59:45 +0200
Subject: [PATCH] Remove circular Also= dependency for systemd-homed

Closes: #1014115
---
 units/systemd-homed-activate.service | 1 -
 1 file changed, 1 deletion(-)

diff --git a/units/systemd-homed-activate.service b/units/systemd-homed-activate.service
index b16fedb..1b18304 100644
--- a/units/systemd-homed-activate.service
+++ b/units/systemd-homed-activate.service
@@ -20,4 +20,3 @@ Type=oneshot
 
 [Install]
 WantedBy=systemd-homed.service
-Also=systemd-homed.service
-- 
2.36.1

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

Reply via email to