Hi,
Alexandre Ghiti wrote:
> Please find attached a patch that enables the releng testsuite.
With my upstream hat on:
I can imagine why it is desirable that log file anomalies cause a non-zero
exit value. But simply aborting the script by "exit 1" seems not to match
its concept (which is by George Danchev).
How about using the delayed exit mechanism which gets into effect if one
of the single tests exits non-zero:
-------------------------------------------------------------------
--- releng/run_all_auto 2020-07-08 12:46:04.314650652 +0200
+++ releng/run_all_auto 2022-06-21 19:26:18.501863413 +0200
# lines, perl regex, leading tabs
grep -n -E "${LIST_KWD}" "${CLOG}"
RET_GREP="$?"
+ ok=0
case ${RET_GREP} in
0) # found
;;
1) # not found
echo "${SELF}: Log file looks clear." # | tee -a ${CLOG}
+ ok=1
;;
*) #
echo "${SELF}: grep returned EXIT CODE: ${RET_GREP}." # | tee
-a ${CLOG}
;;
esac
+ if test "$ok" = 0 && test "$exit_value" = 0
+ then
+ exit_value=1
+ fi
set -e
fi
echo "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~" | tee -a
${CLOG}
------------------------------------------------------------------
With my sponsored packaging helper's hat on, Cc-ing Dominique Dumont
to get an opinion from under the sponsor's hat:
> +++ libisoburn-1.5.4/debian/tests/control
I don't find this described in
https://www.debian.org/doc/manuals/maint-guide
Google finds me
https://people.debian.org/~eriberto/README.package-tests.html
> +Test-Command: cd ./releng && ./run_all_auto -x $(which xorriso)
> +Depends: xorriso, g++, libburn-dev, libisofs-dev
At which occasion will this be run ?
Does this have influence on the dependencies of the binary packages ?
Have a nice day :)
Thomas
