Hi Daniel,
Am 15.06.22 um 19:58 schrieb Daniel Kahn Gillmor:
On Wed 2022-06-15 18:04:09 +0200, Carsten Schoenert wrote:
2) What is needed to modify in the upstream configure script voodoo so
its possible to use the configure options
--with-system-botan
--with-system-bz2
--with-system-jsonc
Is it possible that these three flags aren't relevant any longer
*because* we're using the system rnp?
in comm/third_party/openpgp.configure i see the tests for those options
bracketed within a block that begins:
-----
with only_when(in_tree_librnp):
-----
And i don't see those options anywhere else in the codebase.
thanks for digging into this, I wasn't in the mood to go down that road
until now. :-)
Was happy to get a successful build after months.
It would make sense if those options shouldn't be supplied at all any
longer when we're using the system rnp, and i'd expect that the updated
thunderbird wouldn't acquire any new dependencies from omitting those
changes.
I'd guess that you can probably also remove the build-deps on:
libbotan-2-dev
libbz2-dev
libjson-c-dev
If your analysis is correct than we don't want these build dependencies
any more, right. I've simply forgotten to at least comment these out for
now. The next beta is around the corner to get clear on this. :-)
And the build should complete without an error, but i haven't tested it
myself.
Will do this the next time I import a new upstream version, but my guess
is we can simply remove them now.
--
Regards
Carsten
