Tags: + patch
thanks

Here's the small code change to fix the problem.  I built and
installed the patched version locally, and did 2 successful
add-apt-repository's to add ppa's.  Without the patch, every  attempt
failed (though admittedly each of those attempts was with a single ppa
and sometimes the problem seemed to be the keyserver was down).

I found only a single invocation of apt-key in ppa.py, and so I don't
think there are any other spots that need changing.

BTW, I don't know if my pseudo-headers will do the trick; I'm trying
to add a patch tag to the bug.

On Fri, Jun 10, 2022 at 10:27 PM Debian Bug Tracking System
<ow...@bugs.debian.org> wrote:
>
> Thank you for filing a new Bug report with Debian.
>
> You can follow progress on this Bug here: 1012649: 
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1012649.
>
> This is an automatically generated reply to let you know your message
> has been received.
>
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
>
> As you requested using X-Debbugs-CC, your message was also forwarded to
>   ross.boy...@ucsf.edu
> (after having been given a Bug report number, if it did not have one).
>
> Your message has been sent to the package maintainer(s):
>  Julian Andres Klode <j...@debian.org>
>
> If you wish to submit further information on this problem, please
> send it to 1012...@bugs.debian.org.
>
> Please do not send mail to ow...@bugs.debian.org unless you wish
> to report a problem with the Bug-tracking system.
>
> --
> 1012649: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1012649
> Debian Bug Tracking System
> Contact ow...@bugs.debian.org with problems
diff --git a/debian/changelog b/debian/changelog
index 22af59f..c3a2736 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+software-properties (0.96.20.2-2.1rb1) unstable; urgency=medium
+
+  * Use exported key when adding to approved keys (Closes: #1012649).
+
+ -- Ross Boylan <rossboy...@stanfordalumni.org>  Tue, 14 Jun 2022 21:22:07 -0700
+
 software-properties (0.96.20.2-2.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff --git a/softwareproperties/ppa.py b/softwareproperties/ppa.py
index 23f848d..30b70a7 100644
--- a/softwareproperties/ppa.py
+++ b/softwareproperties/ppa.py
@@ -268,7 +268,7 @@ class AddPPASigningKey(object):
         apt_keyring = os.path.join(trustedgpgd, "%s.gpg" % (
             encode(ppa_info["reference"][1:])))
         res = subprocess.call(["apt-key", "--keyring", apt_keyring, "add",
-            tmp_keyring])
+            tmp_export_keyring])
         # cleanup
         cleanup(tmp_keyring_dir)
         return (res == 0)

Reply via email to