Hi folks,

So, I've pushed a more simple fix for these two bugs:

https://salsa.debian.org/debian/adduser/-/merge_requests/24

One thing that is unclear (and I could not find guidance in the
documentation) is what the intent towards mount points actually is.

For the moment, I have made --remove-all-files perform the same checks
as --remove-home:
        * all mountpoint directories are pruned
        * all no_del_paths matches are pruned

Since mountpoints are never touched, EXCLUDE_FS_TYPES becomes obsolete.

My sense is that this is not the best of intentions, eg. the one edge
case that has to be hard-coded (/home), but this is clearly not ideal
(see also [0]).

My first guess at an ideal interpretation:
        * mount points of EXCLUDE_FS_TYPES are pruned
        * mount points are traversed, but the dir itself not removed
        * keep no_del_paths as is (including the above changes)

Thoughts?

Cheers,
Matt

[0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1012420

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to