On Wed, May 25, 2022 at 07:55:10PM -0500, G. Branden Robinson wrote: > I apologize for filing this bug report a bit prematurely, but I've been > working on building groff in a bullseye chroot lately to prepare for > groff 1.23.0.rc2, and I wanted to document some findings while they were > fresh in my mind.
Thanks for this research! > * Add a dependency on m4. > > o m4 is now required to build. Any m4 that implements the features > documented in the Version 7 Unix m4(1) man page, and the `-D` option, > should suffice. It'll be there anyway due to debhelper → dh-autoreconf → autoconf → m4, but I generally approve of directly specifying direct (build-)dependencies. > * Add a dependency on "cups-client | cups-bsd | lpr". > > This is not due to new development. I confess to being puzzled why > this build dependency isn't already present. groff's configure script > has for years looked for an installed "lpr" command, then fallen back > to "lp". Only "groff -l" uses the detected spooler command, however, > and maybe people just don't do that very often. I think it is > possible that for chroot-built groff packages in Debian--for those > done by the buildds, for instance--the compiled groff command is > silently ignoring the flag. > > https://git.savannah.gnu.org/cgit/groff.git/tree/src/roff/groff/groff.cpp#n408 Isn't this handled by passing PSPRINT=lpr to configure, as we do in debian/rules? I generally prefer this approach over build-dependencies in cases where the build-dependency would just be for path detection and isn't actually used during the build. The fact that /usr/share/groff/1.22.4/font/devps/DESC ends with "print lpr" suggests that this is working. > Please let me know if I can be of assistance. Would you like to co-maintain the package? You're already much more active upstream than I am and you've been doing lots of bug maintenance; I'd be happy for you to do that with a maintainer hat. (My only conditions are that I'd like to keep using git-dpm for patch maintenance and dgit for uploads.) Thanks, -- Colin Watson (he/him) [cjwat...@debian.org]
