Max-Julian Pogner:
> Package: debhelper
> Version: 13.7.1
> Severity: normal
> X-Debbugs-Cc: max-jul...@pogner.at
> 
> Dear Maintainer,
> 
>    * What led up to the situation?
> 
> When using ``dh_testdir``, the following error messages appeared to me:
> 
>> Use of uninitialized value $v in substitution (s///) at 
>> /usr/share/perl5/Debian/Debhelper/Dh_Lib.pm line 1767, <$fd> line 9.
>> Use of uninitialized value $v in substitution (s///) at 
>> /usr/share/perl5/Debian/Debhelper/Dh_Lib.pm line 1768, <$fd> line 9.
> 


Hi,

Thanks for reporting this bug.


> [...]
> 
> I therefore think, that either
> 
>    a) the documentation deb-src-control is incomplete and the source field 
> "Section:" should be marked as required there, or
>    b) the Dh_Lib.pm should assign some default value to variable 
> $source_section after the loop ``while (<$fd>) {`` in lines 1786 to 1835 has 
> finished, or
>    c) Dh_Lib.pm line 1994, which reads
>       
>       > $package_sections{$package} = _strip_spaces($field_values{'section'} 
> // $source_section);;
> 
>       should be changed to cope with the possibility that variable 
> $source_section has value ``undef``, or
>    d) something else?
> 
> 
> Please advise what would be the next step, maybe i can provide a patch then.
> 
> 
> best regards,
> 
> Max
> 
> [...]


I am inclined to go with option C by having `_strip_spaces` cope with
its input being undefined and just immediately returning (or skipping
the stripping part).

Thanks for considering to provide a patch, it is very appreciated. :)  I
have already applied your patch from #1010591.  If you prefer, you are
also very welcome to use salsa.debian.org to provide a merge request at
https://salsa.debian.org/debian/debhelper/-/merge_requests

Thanks,
~Niels

Reply via email to