On 2022-03-13, Andrew Bartlett wrote: > On Sat, 2022-03-12 at 13:53 -0800, Vagrant Cascadian wrote: >> Originally reported as https://bugs.debian.org/1006863 where I proposed >> passing additional arguments via CFLAGS in the debian build system. >> >> Attached is a proof of concept patch that works by adding the argument >> to CFLAGS by patching the upstream buildsystem. >> >> The patch is bit ugly in how it derives the top level source directory >> and likely error-prone... a cleaner way of going about that would be >> much appreciated! >> >> It also requires gcc 8+ or clang 10+ ... making it detect weather the >> argument was supported and only adding it conditionally might be >> desireable. > > testflags=True should be doing that, the CI should help determine if > that works for this option.
Excellent! >> I am not too familiar with samba project processes, let me know if >> there's a better place to send this! > > https://wiki.samba.org/index.php/Contribute shows how to open a Merge > Request for samba. Once you get a gitlab username let me know and you > can skip to using our shared development repo for a full CI. Ok, I've got: https://gitlab.com/vagrantc I'll work on som e updated patches. Should it be a merge request into the samba repository or tevent, or is there a better place for it? > conf.env.srcdir should get you the srcdir you need. Yes, that worked well, thanks! > I guess my main concern is once Samba is packaged etc, can we still get > a full backtrace? How does this interact with debug packages etc? I think the short answer is yes, although it may require passing arguments to the debugger: https://stackoverflow.com/questions/67191647/using-ffile-prefix-map-breaks-debugging Both gdb and lldb allow you to set the path to the source code. live well, vagrant
signature.asc
Description: PGP signature
