Control: tags -1 moreinfo
On Wed, 6 Apr 2022 16:56:37 +0000 (UTC) Eivind Naess <eivn...@yahoo.com> wrote:
Changes for the initial release:
network-manager-sstp (1.2.6-1) unstable; urgency=low
.
* Initial release (Closes: #1006705)
Please untag the moreinfo tag from this bug when you have provided a version that addresses the
following points.
d/control
=========
The Homepage is not really useful. It was NetworkManager's homepage (which is related but not this
project) but now redirects to a general Gnome app website. Please set
https://gitlab.gnome.org/GNOME/network-manager-sstp.
network-manager-sstp's dependency on libsstp-api-0 should be left to
${shlibs:Depends}.
debian/copyright
================
"Upstream-Name: sstp-client" should say network-manager-sstp.
Source: https://sourceforge.net/projects/sstp-client/files/network-manager-sstp/
is missing from the header fields.
po/* copyrights are missing.
shared/nm-utils/gsystem-local-alloc.h's Copyright (C) 2012 Colin Walters <walt...@verbum.org> is
missing.
src/nm-sstp-service.c sshould extend the global Red Hat copyright year range.
debian/patches
==============
Please add metadata for all upstream commits as in patch 0001.
I would edit the git-generated patch so that [PATCH] is not included in the subject and the git
version is not included at the end. Also, please replace the first line with the Origin field
according to https://dep-team.pages.debian.net/deps/dep3/
Please think about publishing a new upstream version to get rid of all patches.
debian/gbp.conf
===============
Please remove. Does not fit your repository.
debian/network-manager-sstp.docs
================================
NEWS is outdated and should not be included.
README is not helpful when the package is available in Debian, so should not be
included.
debian/rules
============
Why is there --without-libnm-glib when those are build dependencies?
override_dh_shlibdeps target is useless. Please remove it.
