On Sat, Apr 02, 2022 at 10:29:05AM -0700, tony mancill wrote: > On Sat, Apr 02, 2022 at 08:11:39PM +0300, Adrian Bunk wrote: > > On Sat, Apr 02, 2022 at 10:39:13AM -0600, Neil Mayhew wrote: > > > On 2022-04-02 09:14, tony mancill wrote: > > > > I will work on patching 8.12.46 and also mention this upstream. The > > > > changelogs for 8.12.45 and 8.12.46 only reference metadata updates. > > > > > > If there was a non-metadata change that wasn't mentioned in the changelog, > > > it will be the second time this has happened in a fairly short period. The > > > other one was https://github.com/google/libphonenumber/pull/2698 which was > > > merged on Jan 7. > > > > The problem is > > https://github.com/google/libphonenumber/commit/5719f3a724d254b21196393d952b71ec3052e6a3 > > > > I have an approximate fix I can polish later this evening, > > unless Tony already has something similar. > > Hi Adrian,
Hi Tony, > Thank you for the pointer. I started picking through the delta between > 8.12.44 and 8.12.46 and it appears that libphonenumber needs to ensure > that absl/hash/internal/hash.cc is linked. I won't have a chance to > work on patch until later in my day (GMT-7) and so would be glad to > receive yours. Otherwise, I will work on it tonight. sorry, I didn't get to it yesterday evening. In case you don't already have something similar, my fix is: https://github.com/AdrianBunk/libphonenumber/commit/a7337f0072293ae07431d5efe7d2f9efa54bfd2d > I will do a full reverse build-deps (ratt) build before uploading. My testcase was the kitinerary FTBFS, which is fixed by the change above. > Cheers, > tony cu Adrian
