Hello, On Thu 17 Mar 2022 at 06:18PM -04, Daniel Kahn Gillmor wrote:
> Hi Sean, thanks for the prompt response. > > On Thu 2022-03-17 11:34:32 -0700, Sean Whitton wrote: >> On Thu 17 Mar 2022 at 01:51PM -04, Daniel Kahn Gillmor wrote: >>> For backward compatibility, if a "maildir" configuration variable is >>> present, it could fall back to the old form of insertion, but emit a >>> warning that it is doing so. >> >> How about using 'notmuch insert --folder=<maildir>' if the old config >> key is present, and not issuing a warning? > > The trouble with that is that --insert is defined "relative to the > top-level directory given by the value of database.mail_root.", whereas > the maildir is a full filesystem path. > > Seems better to me to do a deprecation cycle. It's noisier short term, > but cleaner longterm. > > The other open question here is that "notmuch insert" on its own > defaults to delivering at the top level, whereas notmuch-slurp-debbug > wants to use the "inbox" folder just below the top level. > > I'm personally fine with the default delivery location changing, but if > you think we ought to default to something like --folder=inbox > --create-folder i'd be willing to do that too. I was thinking that some users might want to ensure the new mail goes into a particular subdirectory, as they can do at present (I know Vagrant does this, for example). You can do that with your new insert_args, but why not support both ways? We just File::Spec::abs2rel the old configuration key and use it. Most people won't want to pass any tags, this way the user doesn't have to go read notmuch-insert(1), and we also get backwards compatibility for free. > If we go the --folder=inbox --create-folder route, then we'd need to > decide whether the passthrough arguments would *append* to > --folder=inbox --create-folder, or whether they would *replace* > --folder=inbox --create-folder. I'd lean toward replacement in that > case. > > Also, what would you like this configuration key to be named? I was > thinking "insert_args". Fine with me. > d) if messages are placed by default via "--folder=inbox > --create-folder", how should the config key interact with the default > args? > (if we get to this question, i prefer replacement) Replacement is okay with me. -- Sean Whitton
signature.asc
Description: PGP signature
