Noted. Thanks for the feedback!
On Sat, 26 Feb 2022 at 09:48, Jonas Smedegaard <jo...@jones.dk> wrote: > Hi Caleb, > > Quoting Caleb Adepitan (2022-02-26 00:58:46) > > I just updated my fork of node-es6-promise which was reported to fail > > build with webpack5 earlier. > > Thanks for bringing my attention to this bugreport. > > I guess you did so because I was the last one to work on that package. > > I am however not really involved in maintaining that package - I only > did a minimal change as a "team maintenance" which sort-of means a > fly-by change within the team. > > Although my concrete change involved terser which I notice that your > changes also affect, I really have no special knowledge on how > es6-promise should or should not use terser: All I did was to rename the > call to the terser executable. > > I recommend that you try reach out to the package maintainer - Julien > Puydt <jpu...@debian.org> - whom I assume has the most intimate > knowledge on the packaging setup of this package. > > Now that I am looking anyway, I do notice that upstream does _not_ use > terser but uglify-js (via broccoli-uglify-js). > > Also, upstream seemingly does not use webpack either, but rollup (via > broccoli-rollup). > > You might consider looking into _simplifying_ packaging by using rollup > and uglify-js (but without the broccoli wrappers which are not in > Debian). My point is that maybe *not* using webpack here is a more > sensible way to help migration to webpack5 than to continue deviate from > upstream build approach. Just make sure to coordinate such change with > the maintainer, since that is (from the maintenance point of view) a > more radical change. > > > Kind regards, > > - Jonas > > -- > * Jonas Smedegaard - idealist & Internet-arkitekt > * Tlf.: +45 40843136 Website: http://dr.jones.dk/ > > [x] quote me freely [ ] ask before reusing [ ] keep private
