Source: foma
Severity: normal
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

A typo in the Makefile results in the build path getting embedded in
libfoma.pc:

  
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/foma.html

  /usr/lib/x86_64-linux-gnu/pkgconfig/libfoma.pc

  prefix=/build/1st/foma-0.10.0/debian/tmp/usr
  vs.
  prefix=/build/2/foma-0.10.0/2nd/debian/tmp/usr

The attached patches fix this by fixing the typo in the Makefile.


With this patch applied, foma should build reproducibly on
tests.reproducible-builds.org!


Thanks for maintaining foma!


live well,
  vagrant
From a799f7aab5e81c839f5be79e1512c6e8b9691e6f Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagr...@reproducible-builds.org>
Date: Sat, 26 Feb 2022 00:40:58 +0000
Subject: [PATCH] Makefile: Fix typo when generating libfoma.pc.

The value of prefix isn't sufficienltly quoted for the Makefile, and
results in the build path getting embedded in the installed .pc file.
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index df2ed12..2c2bdcb 100644
--- a/Makefile
+++ b/Makefile
@@ -95,7 +95,7 @@ install: foma libfoma libfoma.pc
 $(OBJS): foma.h
 
 libfoma.pc:
-	echo "prefix=${prefix}" > $@
+	echo "prefix=$${prefix}" > $@
 	echo 'exec_prefix=$${prefix}' >> $@
 	echo 'includedir=$${prefix}/include' >> $@
 	echo 'libdir=$${exec_prefix}/lib' >> $@
-- 
2.35.1

Attachment: signature.asc
Description: PGP signature

Reply via email to