Hi Joshua, Reply follows inline:
Joshua Peisach <itzswirlz2...@outlook.com> writes: > Hi Nicholas, and thank you for helping me! > You're welcome, and I hope you're enjoying the process as a learning experience :-) I don't believe in assigning "yak shaving" busywork, so if there's anything that seems excessively strict to you, please let me know so I can share why it's worth your time. > I've applied your suggestions (I kind of bunted the long description, looked > at other descriptions in other emacs packages). As for d/rules, I tried a > drop-down approach. I hope it works. > Long description is good, thank you, and thank you for changing the section! Oh, sorry, I forgot to mention that proper nouns should remain capitalised in the short description--this is just a nitpick. Rules is much better now; however, Cask will not be integrated into debhelper, because we use dh-elpa. See Bug #837922 for more info. I would be happy to explain in more detail if you have questions about this. > In d/copyright, a small glance at the header of the .el files show the > license (lol) > Yes ;-) The ftpmaster who reviews this package will find discrepancies equally quickly. The following omission is not release critical IMHO (specifically for a GPL-3+ package), but you'll be asked to add: 2019 taku0 and it's possible an ftpmaster will reject the package for having an incomplete copyright file: https://ftp-master.debian.org/REJECT-FAQ.html Finally, #922934, the RFP (request for packaging) bug should be converted to an ITP (intent to package) bug ASAP, and you should take ownership of it. Best practices is to do this before starting work, to avoid duplication of work, especially to avoid the demotivating situation where a DD who isn't aware of your RFS (request for sponsorship) independently creates their own package, then uploads it...making your work a wasted effort. This happened to me once. Claiming an ITP can be done with either pseudo-headers, the "bts" CLI command, or by emailing cont...@bugs.debian.org https://www.debian.org/Bugs/server-control The two commands you're need to use are "retitle" and "owner". When using the pseudo-header method for these commands, "-1" refers to bug being acted upon. You can find an example here: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1003855#21 When you're finished, please remove the moreinfo tag from this bug. If you'd prefer, you can do all BTS operation is one shot by emailing cont...@bugs.debian.org specifying 922934 and 1003855 where appropriate. Don't forget to CC both bugs if you use this method, and don't forget the termination string: https://www.debian.org/Bugs/server-control#thanks Regards, Nicholas
signature.asc
Description: PGP signature
