On Tue, Feb 08, 2022 at 04:53:53AM +0100, Florian Schlichting wrote:
> When you say "the Debian source package", you probably refer to the
> buster version (3.04-13)?
Confirmed, I used buster.
I think I found at least one issue, introduced by these items
in the poppler-0.71.patch:
it = decltype(it){ pages->erase(std::next(it).base()) };
and
- delete (PDFCoreTile *)page->tiles->del(j);
+ itt = page->tiles->erase(itt);
The patch code assumes the GList contains smart pointers, but it doesn't.
When I patched it myself, it didn't fix all the memory leaks, sadly.
> buster is oldstable by now. If you look at
> https://tracker.debian.org/media/packages/x/xpdf/changelog-3.04git20211021-1,
> you'll see that there are several references to fixed bugs about memory
> leaks in newer versions of xpdf in Debian (#945188, #942086, #945188).
> Does any of those sound similar to your problem?
Looking at xpopple code, I see the items inside the vector are
unique_ptrs, so all this stuff is most likely fixed.
> Would you care to try that again with the
> bullseye version (3.04+git20210103-3) that should have all the above
> mentioned memory fixes?
I tried building bullseye's, but it needs a new debhelper and libpoppler.
I'm not sure I should mess with debhelper.
> If that helps, and you cannot upgrade to bullseye just now, I could
> probably upload a buster-backport version of the bullseye xpdf, if
> you're interested?
That would be fantastic!
Thanks,
- Chris
