Hi Jaldhar, On Wed, 26 Feb 2020 00:16:04 -0500 (EST) "Jaldhar H. Vyas" <jald...@debian.org> wrote: > On Sun, 23 Feb 2020, Lucas Nussbaum wrote: > > > Hi, > > > > During a rebuild of all packages in sid, your package failed to build > > on amd64. > > > > Hi Lucas, because I have been long in responding, I just wanted to drop a > quick note that I acknowledge your bug report. I need to do an upstream > release to fix all the issues and I will try and do this ASAP.
Since this bug has been open for a (very)long time, and this package even missed the last release, I NMU'd what I found working. The fix seems to be already there on your corresponding github repository here[1] I have attached the debdiff of my NMU, could you please consider merging? [1]: https://github.com/jaldhar/Module-Starter-Plugin-CGIApp/commit/73ec81f8e648fbda430f3f81ba59428828ea0c18 Regards, Nilesh
diff -Nru libmodule-starter-plugin-cgiapp-perl-0.44/debian/changelog libmodule-starter-plugin-cgiapp-perl-0.44/debian/changelog --- libmodule-starter-plugin-cgiapp-perl-0.44/debian/changelog 2015-09-20 09:29:56.000000000 +0000 +++ libmodule-starter-plugin-cgiapp-perl-0.44/debian/changelog 2022-01-30 16:54:46.000000000 +0000 @@ -1,3 +1,14 @@ +libmodule-starter-plugin-cgiapp-perl (0.44-1.1) unstable; urgency=medium + + * Non-maintainer upload. + * Add patch to fix FTBFS (Closes: #952169) + * d/control: Update versioned dep on libmodule-starter-perl + * d/tests/pkg-perl/SKIP: skip build-deps and syntax.t + + build-deps is skipped since it seems to be tested on itself + + syntax.t: One check on titanium/Modules.pm needs fixing upstream + + -- Nilesh Patra <nil...@debian.org> Sun, 30 Jan 2022 22:24:46 +0530 + libmodule-starter-plugin-cgiapp-perl (0.44-1) unstable; urgency=medium * New upstream version that works properly with Module::Starter 1.70 diff -Nru libmodule-starter-plugin-cgiapp-perl-0.44/debian/control libmodule-starter-plugin-cgiapp-perl-0.44/debian/control --- libmodule-starter-plugin-cgiapp-perl-0.44/debian/control 2015-09-20 09:29:56.000000000 +0000 +++ libmodule-starter-plugin-cgiapp-perl-0.44/debian/control 2022-01-30 16:54:46.000000000 +0000 @@ -2,7 +2,7 @@ Section: perl Priority: optional Build-Depends: debhelper (>= 8), libmodule-build-perl -Build-Depends-Indep: perl (>= 5.6.10-12), libfile-copy-recursive-perl, libfile-dircompare-perl, libmodule-starter-perl (>= 1.700), libhtml-template-perl, libtest-pod-perl (>= 1.22), libtest-pod-coverage-perl (>= 1.08), libtest-mocktime-perl +Build-Depends-Indep: perl (>= 5.6.10-12), libfile-copy-recursive-perl, libfile-dircompare-perl, libmodule-starter-perl (>= 1.760), libhtml-template-perl, libtest-pod-perl (>= 1.22), libtest-pod-coverage-perl (>= 1.08), libtest-mocktime-perl Maintainer: Jaldhar H. Vyas <jald...@debian.org> Standards-Version: 3.9.6 Homepage: http://search.cpan.org/dist/Module-Starter-Plugin-CGIApp/ diff -Nru libmodule-starter-plugin-cgiapp-perl-0.44/debian/patches/adapt-to-module-starter-1.76 libmodule-starter-plugin-cgiapp-perl-0.44/debian/patches/adapt-to-module-starter-1.76 --- libmodule-starter-plugin-cgiapp-perl-0.44/debian/patches/adapt-to-module-starter-1.76 1970-01-01 00:00:00.000000000 +0000 +++ libmodule-starter-plugin-cgiapp-perl-0.44/debian/patches/adapt-to-module-starter-1.76 2022-01-30 16:54:46.000000000 +0000 @@ -0,0 +1,98 @@ +From 13af756ba3800b112c7952a5a2c6bf76b4a0ecde Mon Sep 17 00:00:00 2001 +From: Petr Pisar <ppi...@redhat.com> +Date: Tue, 19 Mar 2019 11:25:09 +0100 +Subject: [PATCH] Adapt to changes in Module-Starter-1.76 + +Module::Starter::Simple changed _license_record() API. Now it returns +a Software::License object or undef. This caused +Module-Starter-Plugin-CGIApp test failures: + + Use of uninitialized value in string eq at /builddir/build/BUILD/Module-Starter-Plugin-CGIApp-0.44/blib/lib/Module/Starter/Plugin/CGIApp.pm line 468. + Use of uninitialized value $license_blurb in scalar chomp at /builddir/build/BUILD/Module-Starter-Plugin-CGIApp-0.44/blib/lib/Module/Starter/Plugin/CGIApp.pm line 488. + [...] + # Failed test 'different files' + # at t/common.pm line 114. + # got: '4' + # expected: '0' + +This patch adapts to the chanegs and increaes a dependency on Module::Starter +to 1.76 version. + +CPAN RT#128881 +--- + Build.PL | 2 +- + META.json | 2 +- + META.yml | 2 +- + lib/Module/Starter/Plugin/CGIApp.pm | 6 +++--- + 4 files changed, 6 insertions(+), 6 deletions(-) + +diff --git a/Build.PL b/Build.PL +index f13c4bf..1eee1ee 100644 +--- a/Build.PL ++++ b/Build.PL +@@ -26,7 +26,7 @@ my $builder = Module::Build->new( + requires => { + 'perl' => 5.008, + 'File::ShareDir' => 0, +- 'Module::Starter' => 1.70, ++ 'Module::Starter' => 1.76, + 'HTML::Template' => 0, + }, + meta_merge => { +diff --git a/META.json b/META.json +index d348950..4705665 100644 +--- a/META.json ++++ b/META.json +@@ -32,7 +32,7 @@ + "requires" : { + "File::ShareDir" : "1.00", + "HTML::Template" : "0", +- "Module::Starter" : "1.7", ++ "Module::Starter" : "1.76", + "perl" : "5.008" + } + } +diff --git a/META.yml b/META.yml +index d2c4fea..626df06 100644 +--- a/META.yml ++++ b/META.yml +@@ -24,7 +24,7 @@ provides: + requires: + File::ShareDir: '1.00' + HTML::Template: '0' +- Module::Starter: '1.7' ++ Module::Starter: '1.76' + perl: '5.008' + resources: + homepage: http://jaldhar.github.com/Module-Starter-Plugin-CGIApp/ +diff --git a/lib/Module/Starter/Plugin/CGIApp.pm b/lib/Module/Starter/Plugin/CGIApp.pm +index 29a102c..8b1a9fc 100644 +--- a/lib/Module/Starter/Plugin/CGIApp.pm ++++ b/lib/Module/Starter/Plugin/CGIApp.pm +@@ -28,7 +28,7 @@ use English qw( -no_match_vars ); + use File::Basename; + use File::Path qw( mkpath ); + use File::Spec (); +-use Module::Starter::BuilderSet; ++use Module::Starter::BuilderSet 1.76; + use HTML::Template; + + =head1 VERSION +@@ -465,7 +465,7 @@ sub _license_blurb { + my $license_record = $self->_license_record(); + + if ( defined $license_record ) { +- if ( $license_record->{license} eq 'perl' ) { ++ if ( $license_record->meta_name eq 'perl' ) { + $license_blurb = <<'EOT'; + This distribution is free software; you can redistribute it and/or modify it + under the terms of either: +@@ -477,7 +477,7 @@ b) the Artistic License version 1.0 or a later version. + EOT + } + else { +- $license_blurb = $license_record->{blurb}; ++ $license_blurb = $license_record->notice; + } + } + else { diff -Nru libmodule-starter-plugin-cgiapp-perl-0.44/debian/patches/series libmodule-starter-plugin-cgiapp-perl-0.44/debian/patches/series --- libmodule-starter-plugin-cgiapp-perl-0.44/debian/patches/series 1970-01-01 00:00:00.000000000 +0000 +++ libmodule-starter-plugin-cgiapp-perl-0.44/debian/patches/series 2022-01-30 16:54:46.000000000 +0000 @@ -0,0 +1 @@ +adapt-to-module-starter-1.76 diff -Nru libmodule-starter-plugin-cgiapp-perl-0.44/debian/tests/pkg-perl/SKIP libmodule-starter-plugin-cgiapp-perl-0.44/debian/tests/pkg-perl/SKIP --- libmodule-starter-plugin-cgiapp-perl-0.44/debian/tests/pkg-perl/SKIP 1970-01-01 00:00:00.000000000 +0000 +++ libmodule-starter-plugin-cgiapp-perl-0.44/debian/tests/pkg-perl/SKIP 2022-01-30 16:54:46.000000000 +0000 @@ -0,0 +1,2 @@ +build-deps +syntax.t
signature.asc
Description: PGP signature
