Control: severity -1 minor

Hi,

On Tue, 18 Jan 2022 at 15:58:43 +0100, Lee Garrett wrote:
> A low-effort fix would be to change the shipped config to
> # DROPBEAR_OPTIONS=""
> to indicate that they're required. Ideally the initramfs hook should either 
> fail
> when unquoted, or accept the full parameter list without quotes. Your call.

It's hopefully clear enough with your patch :-)

Blindly sourcing the config file is in line with how initramfs.conf(5)
is processed AFAIK; a line containing “FOO=bar baz” won't set FOO="bar
baz" in the hook, but instead run `baz` with FOO=bar in its environment.
I'm not against some complex validation logic, but that should probably
be implemented in initramfs-tools not in src:dropbear.

cheers
-- 
Guilhem.

Attachment: signature.asc
Description: PGP signature

Reply via email to