Hi Ben! On Sun, 2022-01-16 at 20:51 -0500, Ben Westover wrote: > Package: sponsorship-requests > Severity: wishlist > > Dear mentors, > > I am looking for a sponsor for my packages "makemkv-oss" and > "makemkv-bin" (they depend on each other):
It's great that you're working on the packaging of MakeMKV. A couple quick comments: It looks like you're basing your packaging work off of the packages I've created and made available; that's wonderful, and I'm glad they were a good starting point. However, I think it would be appropriate (at a minimum) to provide credit in d/copyright. The d/rules file I created for the makemkv-bin package is quite hacky, and work should probably be done to get that into nicer shape if the package is going to be included in the archive. The makemkv-oss package has a lot of vendored libraries. I've tried in the past to remove them, and found that some (like libmatroska) are sufficiently different from the versions in bullseye that they cannot be easily replaced with system libraries. (For instance, see this thread where the libmatroska issue was found: https://forum.makemkv.com/forum/viewtopic.php?p=111826) I foresee this as the largest hurdle to actually getting packages accepted into Debian. Is there a particular reason why you're using debhelper-compat version 12, rather than 13? Mathias
signature.asc
Description: This is a digitally signed message part
