On Tue, 09 Nov 2021 22:28:19 +0100 Lucas Nussbaum <lu...@debian.org> wrote:
> Source: atmel-firmware
> Version: 1.3-4.1
> Severity: important
> Justification: Debian Policy section 4.9
> Tags: bookworm sid
> User: debian...@lists.debian.org
> Usertags: missing-build-arch-indep
>
> Dear maintainer,
>
> Your package does not include build-arch and/or build-indep targets in
> debian/rules. This is required by Debian Policy section 4.9, since 2012.
> https://www.debian.org/doc/debian-policy/ch-source.html#main-building-script-debian-rules
>
> Please note that this is also a sign that the packaging of this software
> could benefit from a refresh. For example, packages using 'dh' cannot be
> affected by this issue.
>
> This mass bug filing was discussed on debian-devel@ in
> https://lists.debian.org/debian-devel/2021/11/msg00052.html .
> The severity of this bug will be changed to 'serious' after a month.
Please find attached a debdiff which converts this package to modern
debhelper. This is MVP required to produce 1) a clean lintian output and
2) a binary package-level no-op vs 1.3-4.1.
I am requesting sponsorship as I am a Debian Maintainer and do not have
full DD upload rights outside my core packages.
(I do not have a major stake in this package, other than noticing it
falling out of testing by this bug.)
Thank you,
Ryan Finnie
diff -Nru atmel-firmware-1.3/atmel-firmware.spec
atmel-firmware-1.3/atmel-firmware.spec
--- atmel-firmware-1.3/atmel-firmware.spec 2021-12-28 22:18:15.000000000
-0800
+++ atmel-firmware-1.3/atmel-firmware.spec 2005-05-07 13:17:12.000000000
-0700
@@ -9,12 +9,12 @@
# For Fedore Core 3 firmware goes in /lib/firmware
# For other distros/releases we use /usr/lib/hotplug/firmware
%define fedoramajorver %(rpm -q --queryformat='%{VERSION}' fedora-release|cut
-d. -f1)
-%define fcnew %(if [ "%{_target}" == "fedora-linux" -o %{fedoramajorver} -ge 3
];then echo 1;else echo 0;fi)
+%define fc3 %(if [ "%{fedoramajorver}" == "3" -o "%{_target}" ==
"fedora-linux" ];then echo 1;else echo 0;fi)
-%if %{fcnew}
+%if %{fc3}
%define firmware_dir /lib/firmware
-%define extraver %{release}fcnew
+%define extraver %{release}fc3
%else
%define firmware_dir /usr/lib/hotplug/firmware
%define extraver %{release}
@@ -29,7 +29,7 @@
Name: atmel-firmware
Version: 1.3
Release: %{extraver}
-License: Distributable
+Copyright: Distributable
Group: System Environment/Kernel
Vendor: Simon Kelley
Packager: Simon Kelley
diff -Nru atmel-firmware-1.3/debian/changelog
atmel-firmware-1.3/debian/changelog
--- atmel-firmware-1.3/debian/changelog 2021-12-28 22:18:15.000000000 -0800
+++ atmel-firmware-1.3/debian/changelog 2021-12-28 22:06:04.000000000 -0800
@@ -1,3 +1,12 @@
+atmel-firmware (1.3-4.2) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * Convert package to debhelper (Closes: #999185)
+ * Convert debian/copyright to DEP-5
+ * Clean lintian (except for pedantic whitespace)
+
+ -- Ryan Finnie <r...@finnie.org> Tue, 28 Dec 2021 22:06:04 -0800
+
atmel-firmware (1.3-4.1) unstable; urgency=medium
* Non-maintainer upload.
diff -Nru atmel-firmware-1.3/debian/conffiles
atmel-firmware-1.3/debian/conffiles
--- atmel-firmware-1.3/debian/conffiles 2021-12-28 22:18:15.000000000 -0800
+++ atmel-firmware-1.3/debian/conffiles 1969-12-31 16:00:00.000000000 -0800
@@ -1 +0,0 @@
-/etc/pcmcia/atmel.conf
diff -Nru atmel-firmware-1.3/debian/control atmel-firmware-1.3/debian/control
--- atmel-firmware-1.3/debian/control 2021-12-28 22:18:15.000000000 -0800
+++ atmel-firmware-1.3/debian/control 2021-12-28 22:06:04.000000000 -0800
@@ -2,10 +2,13 @@
Section: non-free/net
Priority: optional
Maintainer: Simon Kelley <si...@thekelleys.org.uk>
-Standards-Version: 3.5.6.0
+Build-Depends: debhelper, debhelper-compat (= 13), dpkg-dev (>= 1.16.1~)
+Standards-Version: 4.6.0
+Rules-Requires-Root: no
Package: atmel-firmware
Architecture: all
+Depends: ${misc:Depends}
Suggests: wireless-tools
Conflicts: atmelwlandriver-tools
Description: Firmware for Atmel at76c50x wireless networking chips.
diff -Nru atmel-firmware-1.3/debian/copyright
atmel-firmware-1.3/debian/copyright
--- atmel-firmware-1.3/debian/copyright 2021-12-28 22:18:15.000000000 -0800
+++ atmel-firmware-1.3/debian/copyright 2021-12-28 22:02:30.000000000 -0800
@@ -1,64 +1,66 @@
-This Debian package is derived from atmel-firmware-1.2.tar.gz which is
-available on-line at:
+Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
-http://www.thekelleys.org.uk/atmel/atmel-firmware-1.2.tar.gz
-
-The Debian package of atmel-firmware was created by Simon Kelley.
-
-The bin files in the images were generated from header files
-included with the 2.1.1 release of the "Atmel drivers", released
-by Atmel corp in December 2002 and subsequent modifications,
-downloaded from atmelwlandriver.sourceforge.net
-
-The copyright on these files was modified (by Atmel corp)
-in November 2004 to the form shown below.
-
-/***************************************************************************************/
-/* Copyright (c) 2004 Atmel Corporation. All Rights Reserved.
*/
-/* Redistribution and use of the microcode software ( Firmware ) is
*/
-/* permitted provided that the following conditions are met:
*/
-/*
*/
-/* 1. Firmware is redistributed in object code only;
*/
-/* 2. Any reproduction of Firmware must contain the above
*/
-/* copyright notice, this list of conditions and the below
*/
-/* disclaimer in the documentation and/or other materials
*/
-/* provided with the distribution; and
*/
-/* 3. The name of Atmel Corporation may not be used to endorse
*/
-/* or promote products derived from this Firmware without
specific */
-/* prior written consent.
*/
-/*
*/
-/* DISCLAIMER: ATMEL PROVIDES THIS FIRMWARE "AS IS" WITH NO WARRANTIES
OR */
-/* INDEMNITIES WHATSOEVER. ATMEL EXPRESSLY DISCLAIMS ANY EXPRESS,
STATUTORY */
-/* OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
*/
-/* WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
*/
-/* NON-INFRINGEMENT. IN NO EVENT SHALL ATMEL BE LIABLE FOR ANY DIRECT,
*/
-/* INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
*/
-/* (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
*/
-/* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
*/
-/* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
*/
-/* STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
ARISING IN */
-/* ANY WAY OUT OF THE USE OF THIS FIRMWARE, EVEN IF ADVISED OF THE
*/
-/* POSSIBILITY OF SUCH DAMAGE. USER ACKNOWLEDGES AND AGREES THAT THE
*/
-/* PURCHASE OR USE OF THE FIRMWARE WILL NOT CREATE OR GIVE GROUNDS FOR
A */
-/* LICENSE BY IMPLICATION, ESTOPPEL, OR OTHERWISE IN ANY INTELLECTUAL
*/
-/* PROPERTY RIGHTS (PATENT, COPYRIGHT, TRADE SECRET, MASK WORK, OR
OTHER */
-/* PROPRIETARY RIGHT) EMBODIED IN ANY OTHER ATMEL HARDWARE OR FIRMWARE
*/
-/* EITHER SOLELY OR IN COMBINATION WITH THE FIRMWARE.
*/
-/***************************************************************************************/
-
-
-
-The atmel_fwl utility (perl and C verions) is Copyright (c) 2003 Simon
-Kelley and is distributed under the terms of the GNU General Public License
-
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License as published by
- the Free Software Foundation; version 2 dated June, 1991.
-
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- GNU General Public License for more details.
-
-On Debian GNU/Linux systems, the text of the GNU general public license is
-available in the file /usr/share/common-licenses/GPL
+Files: *
+Copyright: 2003 Simon Kelley <si...@thekelleys.org.uk>
+License: GPL-2.0-only
+
+Files:
+ images/*.bin
+ images.usb/*.bin
+Copyright: 2004, Atmel Corporation
+Source: http://www.thekelleys.org.uk/atmel/atmel-firmware-1.2.tar.gz
+Comment:
+ The bin files in the images were generated from header files
+ included with the 2.1.1 release of the "Atmel drivers", released
+ by Atmel corp in December 2002 and subsequent modifications,
+ downloaded from atmelwlandriver.sourceforge.net
+ .
+ The copyright on these files was modified (by Atmel corp)
+ in November 2004 to the form shown below.
+License: Atmel
+
/***************************************************************************************/
+ /* Copyright (c) 2004 Atmel Corporation. All Rights Reserved.
*/
+ /* Redistribution and use of the microcode software ( Firmware ) is
*/
+ /* permitted provided that the following conditions are met:
*/
+ /*
*/
+ /* 1. Firmware is redistributed in object code only;
*/
+ /* 2. Any reproduction of Firmware must contain the above
*/
+ /* copyright notice, this list of conditions and the below
*/
+ /* disclaimer in the documentation and/or other materials
*/
+ /* provided with the distribution; and
*/
+ /* 3. The name of Atmel Corporation may not be used to endorse
*/
+ /* or promote products derived from this Firmware without
specific */
+ /* prior written consent.
*/
+ /*
*/
+ /* DISCLAIMER: ATMEL PROVIDES THIS FIRMWARE "AS IS" WITH NO
WARRANTIES OR */
+ /* INDEMNITIES WHATSOEVER. ATMEL EXPRESSLY DISCLAIMS ANY EXPRESS,
STATUTORY */
+ /* OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
*/
+ /* WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
*/
+ /* NON-INFRINGEMENT. IN NO EVENT SHALL ATMEL BE LIABLE FOR ANY DIRECT,
*/
+ /* INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
*/
+ /* (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
*/
+ /* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
*/
+ /* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
*/
+ /* STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
ARISING IN */
+ /* ANY WAY OUT OF THE USE OF THIS FIRMWARE, EVEN IF ADVISED OF THE
*/
+ /* POSSIBILITY OF SUCH DAMAGE. USER ACKNOWLEDGES AND AGREES THAT THE
*/
+ /* PURCHASE OR USE OF THE FIRMWARE WILL NOT CREATE OR GIVE GROUNDS FOR
A */
+ /* LICENSE BY IMPLICATION, ESTOPPEL, OR OTHERWISE IN ANY INTELLECTUAL
*/
+ /* PROPERTY RIGHTS (PATENT, COPYRIGHT, TRADE SECRET, MASK WORK, OR
OTHER */
+ /* PROPRIETARY RIGHT) EMBODIED IN ANY OTHER ATMEL HARDWARE OR FIRMWARE
*/
+ /* EITHER SOLELY OR IN COMBINATION WITH THE FIRMWARE.
*/
+
/***************************************************************************************/
+
+License: GPL-2.0-only
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; version 2 dated June, 1991.
+ .
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+ .
+ On Debian systems, the full text of the GNU General Public
+ License version 2 can be found in the file
+ `/usr/share/common-licenses/GPL-2'.
diff -Nru atmel-firmware-1.3/debian/docs atmel-firmware-1.3/debian/docs
--- atmel-firmware-1.3/debian/docs 1969-12-31 16:00:00.000000000 -0800
+++ atmel-firmware-1.3/debian/docs 2021-12-28 21:44:35.000000000 -0800
@@ -0,0 +1 @@
+README
diff -Nru atmel-firmware-1.3/debian/postinst atmel-firmware-1.3/debian/postinst
--- atmel-firmware-1.3/debian/postinst 2021-12-28 22:18:15.000000000 -0800
+++ atmel-firmware-1.3/debian/postinst 2021-12-28 21:40:55.000000000 -0800
@@ -19,3 +19,5 @@
if [ -f /var/run/cardmgr.pid ]; then
kill -HUP `cat /var/run/cardmgr.pid`
fi
+
+#DEBHELPER#
diff -Nru atmel-firmware-1.3/debian/rules atmel-firmware-1.3/debian/rules
--- atmel-firmware-1.3/debian/rules 2021-12-28 22:18:15.000000000 -0800
+++ atmel-firmware-1.3/debian/rules 2021-12-28 22:01:06.000000000 -0800
@@ -1,69 +1,13 @@
#!/usr/bin/make -f
-# debian/rules file - for atmel-firmware.
-# Copyright 2004 by Simon Kelley
-# Based on the sample in the debian hello package which carries the following:
-# Copyright 1994,1995 by Ian Jackson.
-# I hereby give you perpetual unlimited permission to copy,
-# modify and relicense this file, provided that you do not remove
-# my name from the file itself. (I assert my moral right of
-# paternity under the Copyright, Designs and Patents Act 1988.)
-# This file may have to be extensively modified
-
-package=atmel-firmware
-
-build:
- $(checkdir)
-
-clean:
- $(checkdir)
- rm -rf atmel_fwl *~ images/*~ images.usb/*~ debian/tmp debian/*~
debian/files* debian/substvars
-
-binary-arch: checkroot
- $(checkdir)
-# There are no architecture-dependent files to be uploaded
-# generated by this package. If there were any they would be
-# made here.
-
-binary-indep: checkroot
- $(checkdir)
- rm -rf debian/tmp
- install -d debian/tmp/DEBIAN\
- -d debian/tmp/usr/sbin\
- -d debian/tmp/lib/firmware\
- -d debian/tmp/etc/pcmcia\
- -d debian/tmp/usr/share/man/man8\
- -d debian/tmp/usr/share/doc/$(package)
- install -m 755 debian/postinst debian/tmp/DEBIAN
- install -m 644 debian/conffiles debian/tmp/DEBIAN
- install -m 755 atmel_fwl.pl debian/tmp/usr/sbin/atmel_fwl
- install -m 644 atmel.conf debian/tmp/etc/pcmcia
- install -m 644 images/* debian/tmp/lib/firmware
- install -m 644 images.usb/* debian/tmp/lib/firmware
- cp README debian/tmp/usr/share/doc/$(package)/README
- gzip debian/tmp/usr/share/doc/$(package)/README
- cp debian/changelog debian/tmp/usr/share/doc/$(package)/changelog.Debian
- gzip -9 debian/tmp/usr/share/doc/$(package)/changelog.Debian
- cp debian/copyright debian/tmp/usr/share/doc/$(package)/copyright
- cp atmel_fwl.8 debian/tmp/usr/share/man/man8
- gzip -9 debian/tmp/usr/share/man/man8/atmel_fwl.8
- cd debian/tmp && find . -type f ! -regex '.*DEBIAN/.*' -printf '%P\0' |
xargs -r0 md5sum > DEBIAN/md5sums
- dpkg-gencontrol -isp
- chown -R root.root debian/tmp
- chmod -R g-ws debian/tmp
- dpkg --build debian/tmp ..
-
-define checkdir
- test -d images -a -f debian/rules
-endef
-
-# Below here is fairly generic really
-
-binary: binary-indep binary-arch
-
-checkroot:
- $(checkdir)
- test root = "`whoami`"
-
-.PHONY: binary binary-arch binary-indep clean checkroot
+%:
+ dh $@
+override_dh_auto_install:
+ dh_auto_install
+ install -d -m 0755 debian/atmel-firmware/lib/firmware
+ install -m 0644 images/*.bin debian/atmel-firmware/lib/firmware
+ install -m 0644 images.usb/*.bin debian/atmel-firmware/lib/firmware
+ install -D -m 0755 atmel_fwl.pl debian/atmel-firmware/usr/sbin/atmel_fwl
+ install -D -m 0644 atmel_fwl.8
debian/atmel-firmware/usr/share/man/man8/atmel_fwl.8
+ install -D -m 0644 atmel.conf
debian/atmel-firmware/etc/pcmcia/atmel.conf
diff -Nru atmel-firmware-1.3/debian/source/format
atmel-firmware-1.3/debian/source/format
--- atmel-firmware-1.3/debian/source/format 1969-12-31 16:00:00.000000000
-0800
+++ atmel-firmware-1.3/debian/source/format 2021-12-28 21:24:28.000000000
-0800
@@ -0,0 +1 @@
+3.0 (quilt)
