Package: youtube-dl
Version: 2021.06.06-1
Severity: wishlist

Hey.

Guess this mostly applies to https://salsa.debian.org/debian/yt-dlp now ;-)

I think one could further improve 
0002-Disable-upstream-s-autoupdate-mechanism.patch


Ideally I'd remove yt-dlp/yt_dlp/update.py at all, so I've checked where it's 
used


t-dlp$ grep -R "from[[:space:]]" | grep '\.update'

test/test_update.py.disabled:from yt_dlp.update import rsa_verify
        => seems to be disabled anyway, but perhaps one can further drop this?

yt_dlp/YoutubeDL.py:from .update import detect_variant
        => ok that may be called, but it's harmless (no evil downloader)
           but we cannot just drop update.py at all

yt_dlp/__init__.py:from .update import run_update
        => this, is already commented by the current patch, so we could
           comment the import too
           and
           remove run_update alltogether


yt_dlp/utils.py:    from .update import is_non_updateable
        => still needed, I guess.. but does that even work as is for us?


Well I guess at least we could drop run_update.
What do you think?


Cheers,
Chris.

Reply via email to