On Wed, Dec 15, 2021, 13:29 Johannes Schauer Marin Rodrigues < jo...@debian.org> wrote:
> Hi Felipe, > > Quoting Felipe Sateler (2021-12-15 19:56:29) > > THanks for your patience. Your MRs are very much welcome. > > thank you for your review! > > > On Mon, Nov 15, 2021 at 10:09 AM Johannes Schauer Marin Rodrigues < > jo...@debian.org> wrote: > > > > https://salsa.debian.org/debian/init-system-helpers/-/merge_requests/17 > > > > > > If you like those changes, I can rebase the DPKG_ROOT patch on top of > it > > > and run the entire test suite with DPKG_ROOT enabled instead of > fakechroot. > > I think we should run both (so that we test both pathways). > > Yes. That's what's implemented in MR 12 already. See override_dh_auto_test > in > debian/rules: > > > https://salsa.debian.org/debian/init-system-helpers/-/merge_requests/12/diffs#8756c63497c8dc39f7773438edf53b220c773f67_41_41 > > Maybe you can merge MR 18 first? Then it becomes easier to make sure that > any > additional changes break nothing because then any change I do to a MR will > trigger the salsa CI: > > https://salsa.debian.org/debian/init-system-helpers/-/merge_requests/18 But this should require mr 17 first, no? > > > Thanks! > > cheers, josch
