On Tue, Nov 30, 2021 at 11:53:23AM -0800, Norman Rasmussen wrote:
> --- a/src/unix/stdpaths.cpp
> +++ b/src/unix/stdpaths.cpp
> @@ -260,6 +260,8 @@ wxString wxStandardPaths::GetDocumentsDir() const
> value.Replace(wxT("$HOME"), homeDir);
> value.Trim(true);
> value.Trim(false);
> + // Remove quotes
> + value.Replace("\"", "", true /* replace all */);
> if (!value.IsEmpty() && wxDirExists(value))
> return value;
> else
>
> While I don't really agree with _how_ the quotes are removed (the string
> should be unquoted like wxFileConfig does with FilterInValue instead of
> just stripping all of the quotes)
Indeed, the code around here will get various corner cases wrong.
Have you tried to get upstream to address this?
> I would like this part of the
> upstream commit to be backported to the current Debian package so that
> the returned value is useable (and I don't want to wait for a new stable
> release of wxWidgets).
I'd strongly encourage you to get this backported upstream to the
WX_3_0_BRANCH. That way it's fixed for everybody in the next 3.0.x
release.
If we only fix this in Debian, people will need to work around
this in their application code anyway for Linux distros not derived from
Debian.
(And then we can cherry-pick from WX_3_0_BRANCH - I'm just much more
hesitant to cherry pick fixes that aren't backported upstream.)
Cheers,
Olly
