We generally use a script to update the maintainer field that sets it to "Ubuntu Developers", which is why I didn't initially add that check. However, someone could manually add Canonical in there so your patch looks good to me!
Thanks, William On Wed, 24 Nov 2021 23:59:32 +0100 Guillem Jover <guil...@debian.org> wrote: > Hi! > > On Wed, 2021-11-24 at 16:02:22 -0600, William 'jawn-smith' Wilson wrote: > > Package: dpkg > > Severity: minor > > Tags: patch > > User: ubuntu-de...@lists.ubuntu.com > > Usertags: origin-ubuntu jammy ubuntu-patch > > > dpkg-source will do a check for a scenario where the maintainer field in > > d/control does not contain "ubuntu" and the DEBEMAIL environment > > variable ends in @ubuntu.com. There are some Canonical employees that > > use an @canonical.com email address instead, so we should expand this > > check to also trigger on DEBEMAIL values that end in @canonical.com > > > In Ubuntu, the attached patch was applied to achieve the following: > > > > Have dpkg-source fail in the aforementioned scenario, rather than a > > warning. > > > > * scripts/Dpkg/Vendor/Ubuntu.pm: when checking for the correct > > maintainer field, also look for @canonical.com email addresses > > (LP: #1951988) > > I think the patch was missing checking for canonical also in the > field. Attached what I'm planning to merge. Let me know if the address > I used in the attribution is correct or you'd prefer something else > (just copied the one in the email)? > > Thanks, > Guillem
