Hi Dominique,

Quoting Dominique Dumont (2021-11-19 18:06:00)
> On Thu, 12 Apr 2018 23:26:53 +0200 Jonas Smedegaard <d...@jones.dk> wrote:
> > It is (slower but) more reliable to use "--lines 0".
> 
> Indeed. I have a similar case with #1000179 where licensecheck does not get 
> copyright assignment from a LICENSE file:
> 
> $ licensecheck --copyright LICENSE 
> LICENSE: *No copyright* Apache License 2.0
> 
> But it gets the copyright with --lines option:
> 
> $ licensecheck --copyright LICENSE -l 0
> LICENSE: Apache License 2.0
>   [Copyright: patent, trademark, and / license to reproduce, prepare 
> Derivative Works of, / License. Subject to the terms and conditions of / 2017 
> Sourced Technologies S.L.]
> 
> Would it be possible to use --lines 0 with files containing a lot of capital 
> letters (like LICENSE.* README*) and so on... These files tend to be 
> relatively 
> short compared to other source files.

Sounds like a bad idea to me to dynamically adapt scanning "depth" based 
on filename naming style.

You write in bug#1000179 that --lines=0
> could really slow down copyright update

I would appreciate some numbers about actual slowdown.

On a related note, it is bad style to fork general public license files 
- I have reported this incident upstream: 
https://github.com/go-git/go-billy/issues/20


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

Attachment: signature.asc
Description: signature

Reply via email to