Source: dcmtk
Version: 3.6.5-1
Tags: patch upstream
User: debian-cr...@lists.debian.org
Usertags: ftcbfs
dcmtk fails to cross build from source, because it uses a TRY_RUN check
to determine whether char is signed. Such a check does not have to run
code (which does not work during cross compilation), but can be written
as a compile only test. Please consider applying the attached patch to
fix this instance of TRY_RUN. There are more TRY_RUN to be fixed to make
dcmtk cross buildable though. So please consider applying the attached
patch as an incremental step.
Helmut
--- a/CMake/dcmtkTestCharSignedness.cc
+++ /dev/null
@@ -1,6 +0,0 @@
-/* Return 1 for char signed and 0 for char unsigned. */
-int main()
-{
- unsigned char uc = 255;
- return (*reinterpret_cast<char*>(&uc) < 0)?1:0;
-}
--- a/CMake/GenerateDCMTKConfigure.cmake
+++ b/CMake/GenerateDCMTKConfigure.cmake
@@ -753,19 +753,21 @@ endif()
if(NOT DEFINED C_CHAR_UNSIGNED)
message(STATUS "Checking signedness of char")
- DCMTK_TRY_RUN(C_CHAR_SIGNED C_CHAR_SIGNED_COMPILED "${CMAKE_BINARY_DIR}/CMakeTmp/Char"
- "${DCMTK_SOURCE_DIR}/CMake/dcmtkTestCharSignedness.cc"
- COMPILE_OUTPUT_VARIABLE C_CHAR_SIGNED_COMPILE_OUTPUT)
+ DCMTK_TRY_COMPILE(C_CHAR_SIGNED_COMPILED "char is signed"
+ "// Fail compile for unsigned char.
+int main()
+{
+ unsigned char uc = 255;
+ char *unused_array[(*reinterpret_cast<char*>(&uc) < 0)?1:-1];
+ return 0;
+}
+")
if(C_CHAR_SIGNED_COMPILED)
- if(C_CHAR_SIGNED)
- message(STATUS "Checking signedness of char -- signed")
- set(C_CHAR_UNSIGNED 0 CACHE INTERNAL "Whether char is unsigned.")
- else()
- message(STATUS "Checking signedness of char -- unsigned")
- set(C_CHAR_UNSIGNED 1 CACHE INTERNAL "Whether char is unsigned.")
- endif()
+ message(STATUS "Checking signedness of char -- signed")
+ set(C_CHAR_UNSIGNED 0 CACHE INTERNAL "Whether char is unsigned.")
else()
- message(STATUS "Checking signedness of char -- failed")
+ message(STATUS "Checking signedness of char -- unsigned")
+ set(C_CHAR_UNSIGNED 1 CACHE INTERNAL "Whether char is unsigned.")
endif()
endif()
