Source: kmplayer
Version: 1:0.12.0b-3
Severity: normal
Tags: patch
X-Debbugs-Cc: 997...@bugs.debian.org, 955...@bugs.debian.org,
967...@bugs.debian.org
It appears that several bugs in the kmplayer package, including RC
bug #997118, could be resolved by not compiling the NPAPI player,
/usr/bin/knpplayer.
I am not a kmplayer (or KDE) user, but if I'm reading correctly, knpplayer
appears to be a standalone host for NPAPI browser plugins, in particular
the obsolete/unmaintained/insecure Flash player. NPAPI is no longer
supported by the browsers themselves, and relies on the deprecated GTK
2 library (which I think is part of the API, so cannot easily be removed).
Is this still useful in 2021? If not, please disable it in the Debian
package, and talk to upstream about removing it altogether.
The attached patch compiles successfully (resolving #997118) but has
not otherwise been tested. debian/patches/aarch64.diff could probably
also be dropped if knpplayer is disabled.
If the NPAPI player is still required, there are a couple of other ways
that #997118 could be resolved (it's similar to #992329). I'll try to
provide a patch for those later.
smcv
>From 9983dc62a58c9ebf62ba441bf8729e26490e376c Mon Sep 17 00:00:00 2001
From: Simon McVittie <s...@debian.org>
Date: Thu, 11 Nov 2021 11:04:01 +0000
Subject: [PATCH] Don't build knpplayer
It depends on the deprecated GTK 2 and dbus-glib libraries, and does
not compile successfully with the current version of GLib. According to
<https://docs.kde.org/trunk5/en/kmplayer/kmplayer/npp.html>, it is only
useful after manual configuration, and is used to host NPAPI browser
plugins like the one for Flash, which are insecure and obsolete.
Closes: #955907, #967558, #997118
---
debian/control | 4 ++--
debian/rules | 3 +++
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/debian/control b/debian/control
index e9d4de28..33b42c1b 100644
--- a/debian/control
+++ b/debian/control
@@ -18,8 +18,8 @@ Build-Depends: debhelper (>= 11~), cmake, pkg-kde-tools (>= 0.15.16),
libkf5mediaplayer-dev,
libkf5parts-dev,
libkf5widgetsaddons-dev,
- libcairo2-dev, libdbus-1-dev, libdbus-glib-1-dev,
- libgtk2.0-dev, libx11-dev, libxt-dev
+ libcairo2-dev,
+ libx11-dev, libxt-dev
Standards-Version: 4.2.1
Homepage: http://kmplayer.kde.org
Vcs-Browser: https://salsa.debian.org/qt-kde-team/extras/kmplayer
diff --git a/debian/rules b/debian/rules
index 22b50311..0d3f6722 100755
--- a/debian/rules
+++ b/debian/rules
@@ -5,6 +5,9 @@ export DEB_LDFLAGS_MAINT_APPEND := -Wl,--as-needed
%:
dh $@ --with kf5
+override_dh_auto_configure:
+ dh_auto_configure -- -DKMPLAYER_BUILT_WITH_NPP=OFF
+
override_dh_install:
dh_install
chmod +x debian/kmplayer/usr/share/kmplayer/find-media.sh
--
2.33.1
