On Sun, Feb 21, 2021 at 03:24:26PM -0500, Olek Wojnar wrote: > I have run into this exact issue with bazel-bootstrap builds. [1] I love > what blhc does so I'd rather not disable it due to these false positives, > but I also like for the Salsa CI to let me know when a recent commit has > caused a problem, and constant test failures mask that. > > Would it be possible to change the regex so that it will also accept a " or > a ' next to the spaces surrounding the flag? That way all of the three > following would be considered valid: > -D_FORTIFY_SOURCE=2 > '-D_FORTIFY_SOURCE=2' > "-D_FORTIFY_SOURCE=2"
Hello Olek, sorry for the late reply. The issue you mentioned is different from the originally reported bug and much easier to fix. Should be fixed with [1], please check and report back. The original issue is that blhc treats the line as a compiler line because it sees the "gcc" in the environment variable (not noticing that it's just an environment variable and not a command). > Thanks for your work on this package, it's a very useful indicator of > regressions or other coding issues! You're welcome! Regards Simon [1]: https://ruderich.org/simon/gitweb/?p=blhc/blhc.git;a=commitdiff;h=06b7783ef223d0f58804f3f08d27c45dc3b97351 -- + privacy is necessary + using gnupg http://gnupg.org + public key id: 0x92FEFDB7E44C32F9
signature.asc
Description: PGP signature
