Control: tags 990246 +patch On 2021-08-26, Sebastian Ramacher wrote: > On 2021-08-25 10:08:07 -0700, Vagrant Cascadian wrote: >> On 2021-08-25, Sebastian Ramacher wrote: >> > On 2021-06-23 13:16:47, Vagrant Cascadian wrote: >> >> The build username and build system hostname are embedded in binaries >> >> shipped in vlc: >> >> >> >> >> >> https://tests.reproducible-builds.org/debian/rb-pkg/bullseye/amd64/diffoscope-results/vlc.html >> >> >> >> ./usr/lib/x86_64-linux-gnu/libvlccore.so.9.0.0 >> >> >> >> pbuilder1 >> >> vs. >> >> pbuilder2 >> >> >> >> ionos11-amd64 >> >> vs. >> >> i-capture-the-hostname >> >> >> >> The attached patch fixes this by setting VLC_COMPILE_BY and >> >> VLC_COMPILE_HOST to empty values in configure.ac. >> > >> > NACK. This information is part of the logs that are usually requested >> > from users by upstream. We want to have this information included in the >> > log so that upstream can easily identify where the logs are coming from >> > and what they are using. And for that purpose, a self-built deb or one >> > from a downstream distribution is different from the Debian one. >> >> The username and hostname of the build seems a rather imprecise way to >> find out information about the origin of the build... >> >> In the context of Debian, a given package+version has specific build >> logs associated with it findable at https://buildd.debian.org/PACKAGE > > A package version doesn't tell me if it's the same version but built by > Debian, built by Ubuntu, built by Devuan, etc. And given that we receive > bug reports from downstream distributions also in the Debian BTS, that's > something I want to know when triaging those reports. > > I'd be fine if that says for example, $DIST $ARCH buildd. That would > only leave custom built debs.
Attached is a patch that was merged upstream, allowing overriding VLC_COMPILE_BY and VLC_COMPILE_HOST from configure. The second patch modifies Debian rules to pass information about the build host (DEB_VENDOR, DEB_HOST_ARCH, DEB_HOST_GNU_TYPE) via VLC_COMPILE_BY and VLC_COMPILE_HOST passed to configure. Hopefully this is sufficient to address the concerns of uniquely identifying a build... Thanks for considering! live well, vagrant
signature.asc
Description: PGP signature
