Hi Axel,
On Wed, Sep 22, 2021 at 04:45:45PM +0200, Axel Beckert wrote:
> Package: iptables-netflow-dkms
> Version: 2.6-1
> Severity: serious
>
> DKMS make.log for ipt-netflow-2.6 for kernel 5.14.0-1-amd64 (x86_64)
> Wed Sep 22 16:33:59 CEST 2021
> ./gen_compat_def > compat_def.h
> Test symbol xt_family linux/netfilter_ipv4/ip_tables.h declared
> Test struct timeval linux/ktime.h undeclared
> Test struct proc_ops linux/proc_fs.h declared
> Test symbol synchronize_sched linux/rcupdate.h undeclared
> Test symbol nf_bridge_info_get linux/netfilter_bridge.h declared
> Test struct vlan_dev_priv linux/if_vlan.h declared
> Compiling 2.6 for kernel 5.14.6
> make -C /lib/modules/5.14.0-1-amd64/build
> M=/var/lib/dkms/ipt-netflow/2.6/build modules
> make[1]: warning: jobserver unavailable: using -j1. Add '+' to parent make
> rule.
> make[1]: Entering directory '/usr/src/linux-headers-5.14.0-1-amd64'
> CC [M] /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.o
> /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c:96:4: warning: #warning
> "Requested physdev is not compiled." [-Wcpp]
> 96 | # warning "Requested physdev is not compiled."
> | ^~~~~~~
> /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c: In function ‘nf_seq_show’:
> /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c:762:39: warning: format
> ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type
> ‘s64’ {aka ‘long long int’} [-Wformat=]
> 762 | seq_printf(seq, " Flows selected %lu, discarded %lu.",
> | ~~^
> | |
> | long unsigned int
> | %llu
> 763 | atomic64_read(&flows_selected),
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | |
> | s64 {aka long long int}
> /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c:762:54: warning: format
> ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type
> ‘s64’ {aka ‘long long int’} [-Wformat=]
> 762 | seq_printf(seq, " Flows selected %lu, discarded %lu.",
> | ~~^
> | |
> | long unsigned int
> | %llu
> 763 | atomic64_read(&flows_selected),
> 764 | atomic64_read(&flows_observed) -
> atomic64_read(&flows_selected));
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | |
> | s64 {aka long long int}
> /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c:766:39: warning: format
> ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type
> ‘s64’ {aka ‘long long int’} [-Wformat=]
> 766 | seq_printf(seq, " Flows selected %lu.",
> atomic64_read(&flows_selected));
> | ~~^
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | | |
> | | s64 {aka long long int}
> | long unsigned int
> | %llu
> /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c: At top level:
> /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c:1946:13: error: static
> declaration of ‘sk_error_report’ follows non-static declaration
> 1946 | static void sk_error_report(struct sock *sk)
> | ^~~~~~~~~~~~~~~
> In file included from
> /usr/src/linux-headers-5.14.0-1-common/include/net/inet_sock.h:22,
> from
> /usr/src/linux-headers-5.14.0-1-common/include/linux/udp.h:16,
> from /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c:33:
> /usr/src/linux-headers-5.14.0-1-common/include/net/sock.h:2287:6: note:
> previous declaration of ‘sk_error_report’ was here
> 2287 | void sk_error_report(struct sock *sk);
> | ^~~~~~~~~~~~~~~
> In file included from /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c:79:
> /var/lib/dkms/ipt-netflow/2.6/build/murmur3.h: In function ‘murmur3’:
> /var/lib/dkms/ipt-netflow/2.6/build/murmur3.h:35:14: warning: this statement
> may fall through [-Wimplicit-fallthrough=]
> 35 | case 3: k1 ^= tail[2] << 16; /* FALLTHROUGH */
> | ~~~^~~~~~~~~~~~~~~~
> /var/lib/dkms/ipt-netflow/2.6/build/murmur3.h:36:3: note: here
> 36 | case 2: k1 ^= tail[1] << 8; /* FALLTHROUGH */
> | ^~~~
> /var/lib/dkms/ipt-netflow/2.6/build/murmur3.h:36:14: warning: this statement
> may fall through [-Wimplicit-fallthrough=]
> 36 | case 2: k1 ^= tail[1] << 8; /* FALLTHROUGH */
> | ~~~^~~~~~~~~~~~~~~
> /var/lib/dkms/ipt-netflow/2.6/build/murmur3.h:37:3: note: here
> 37 | case 1: k1 ^= tail[0];
> | ^~~~
> /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c: In function
> ‘parse_sampler’:
> /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c:2228:7: warning: this
> statement may fall through [-Wimplicit-fallthrough=]
> 2228 | ret = -EINVAL;
> /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.c:2230:2: note: here
> 2230 | case '\0': /* empty */
> | ^~~~
> make[3]: ***
> [/usr/src/linux-headers-5.14.0-1-common/scripts/Makefile.build:276:
> /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.o] Error 1
> make[2]: *** [/usr/src/linux-headers-5.14.0-1-common/Makefile:1882:
> /var/lib/dkms/ipt-netflow/2.6/build] Error 2
> make[1]: *** [/usr/src/linux-headers-5.14.0-1-common/Makefile:232:
> __sub-make] Error 2
> make[1]: Leaving directory '/usr/src/linux-headers-5.14.0-1-amd64'
> make: *** [Makefile:27: ipt_NETFLOW.ko] Error 2
>
> Might be an upstream issue. Will dig deeper later.
Upstream commit
https://github.com/aabc/ipt-netflow/commit/66e4304101010108892376866334ec9317b427d8
should address this issue. Linux upstream 5.14-rc1 had e3ae2365efc1
("net: sock: introduce sk_error_report").
Regards,
Salvatore
