Le mar. 21 sept. 2021 à 08:58, Ondrej Zary <ond...@zary.sk> a écrit : > > On Tuesday 21 September 2021, Bastien ROUCARIES wrote: > > Le mar. 21 sept. 2021 à 07:55, Ondrej Zary <ond...@zary.sk> a écrit : > > > > > > On Monday 20 September 2021, Bastien Roucariès wrote: > > > > Le lundi 20 septembre 2021, 19:32:52 UTC Bastien ROUCARIES a écrit : > > > > Could you try one by one the following untested patch. Please compile > > > > and run > > > > the testsuite. > > > > > > The first one fails to compile: > > > In file included from ../src/util-inl.h:28, > > > from ../src/aliased_buffer.h:7, > > > from ../src/memory_tracker.h:12, > > > from ../src/memory_tracker-inl.h:6, > > > from ../src/base_object.h:27, > > > from ../src/async_wrap.h:27, > > > from ../src/async_wrap-inl.h:27, > > > from ../src/async_wrap.cc:22: > > > ../src/util.h:210:11: error: ‘Persistent’ does not name a type; did you > > > mean ‘gethostent’? > > > const Persistent<TypeName>& persistent); > > > > Add on the top of the files using v8::Global; > > and replace const Persistent<TypeName>& persistent by const > > Global<Function>& persistent > > You probably mean Global<TypeName>& persistent. > > Then ENVIRONMENT_STRONG_PERSISTENT_VALUES is undefined: > In file included from ../src/env-inl.h:28, > from ../src/base_object-inl.h:28, > from ../src/async_wrap-inl.h:28, > from ../src/async_wrap.cc:22: > ../src/env.h:1036:40: error: ‘V’ has not been declared > ENVIRONMENT_STRONG_PERSISTENT_VALUES(V) > ^ > ../src/env.h:1036:41: error: ISO C++ forbids declaration of > ‘ENVIRONMENT_STRONG_PERSISTENT_VALUES’ with no type [-fpermissive] > ENVIRONMENT_STRONG_PERSISTENT_VALUES(V) > ^ > ../src/env.h:1036:41: error: expected ‘;’ at end of member declaration > ENVIRONMENT_STRONG_PERSISTENT_VALUES(V)
:S Jeremy backport will be hard. If we use std::shared_ptr we leak memory
