On 9/18/21 11:20 PM, Samuel Thibault wrote: > Matthias Klose, le ven. 17 sept. 2021 12:18:53 +0200, a ecrit: >> On 9/12/21 9:37 PM, Samuel Thibault wrote: >>> Hello, >>> >>> From: Debian FTP Masters <ftpmas...@ftp-master.debian.org> >>>> * Fix CFLAGS in the python3.x-config scripts. Closes: #992669, #989000. >>> >>> Thanks for fixing CFLAGS! >>> >>> However LDFLAGS are still missing: >>> >>> Samuel Thibault, le sam. 22 mai 2021 23:10:16 +0200, a ecrit: >>>> blhc also notices that LDFLAGS is not getting included: >>>> >>>> https://salsa.debian.org/a11y-team/brltty/-/jobs/1660079 >>>> >>>> 2438:LDFLAGS missing (-Wl,-z,now): x86_64-linux-gnu-gcc -pthread -shared >>>> -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-z,relro -g -fwrapv -O2 -Wl,-z,relro >>>> -g -fwrapv -O2 -g >>>> -ffile-prefix-map=/build/python3.9-RNBry6/python3.9-3.9.2=. >>>> -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time >>>> -D_FORTIFY_SOURCE=2 ./../../../Bindings/Python/bindings.o ./brlapi.auto.o >>>> -L./../../Programs -lbrlapi -lpthread -o >>>> build/lib.linux-x86_64-3.9/brlapi.cpython-39-x86_64-linux-gnu.so >>> >>> That is still the case, see for instance: >>> >>> https://salsa.debian.org/a11y-team/brltty/-/jobs/1938826 >> >> I don't see these flags anymore in >> >> /usr/lib/python3.9/_sysconfigdata__x86_64-linux-gnu.py > > They are there: > > 'BLDSHARED': 'x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 ' > '-Wl,-Bsymbolic-functions ' > ' -Wl,-z,relro -g ' > '-fwrapv -O2 ', > > 'LDFLAGS': ' -Wl,-z,relro -g -fwrapv ' > '-O2 ', > > The command shown above is basically > > $BLDSHARED $LDFLAGS $CFLAGS ./../../../Bindings/Python/bindings.o [...] > > (where CFLAGS is indeed now properly coming from environment, but > LDFLAGS is still as set in _sysconfigdata__x86_64-linux-gnu.py and not > from the environment.
ahh, so -Wl,-z,relro was still set...
