control: tag -1 + patch Le sam. 4 sept. 2021 à 15:27, Chris Lamb <la...@debian.org> a écrit : > > tags 993662 - patch > thanks > > Hi Bastien, > > > Doing some code review on mozilla I found this interesting file > > https://sources.debian.org/src/firefox- > > esr/78.13.0esr-1/js/src/frontend/BinASTEnum.h/?hl=1#L1 > > > > // This file was autogenerated by binjs_generate_spidermonkey, > > // please DO NOT EDIT BY HAND. > > Interesting idea. But files with contents such as these aren't a > problem in themselves. A problem only arises, at least from an > ftpmaster point of view, when there isn't the corresponding, say, > binjs_generate_spidermonkey script. (Imagine a long debate about > "corresponding source code" here; better held elsewhere.) > > So, unless I'm missing something, I don't think this is something > Lintian should warn about, at any severity level. like other autogenerated a pedantic tag will help here see for instance here https://lintian.debian.org/tags/source-contains-prebuilt-javascript-object or even like https://lintian.debian.org/tags/very-long-line-length-in-source-file
I agree with your diagnostic, but in fact: 1. best packaging practice is to convince upstream to remove this file and rebuild from source 2. good packaging pratice is to repack with a +ds suffix, in order to be robust and rebuild all the time 3. a lintian tag will be a strong remainder to check manually this file, repack or even add a lintian override thus a documentation why it is not important for DFSG. I really prefer to have a tag, ftpmaster is a bottlenet more than maintainer time, so every little bit piece of documentation and help is I think welcome here. A pedantic time is just the right level for this kind of stuff... > > > Tags: patch > > (I assume this was a mistake, rather than you missing an attachment? > Feel free to revert if necessary.) Here https://salsa.debian.org/lintian/lintian/-/merge_requests/366 > > > Regards, > > -- > ,''`. > : :' : Chris Lamb > `. `'` la...@debian.org 🍥 chris-lamb.co.uk > `-
