On Sun, Apr 23, 2006 at 08:08:47PM -0400, Joey Hess wrote:
> Hi Ted.. to summarize what needs doing for this bug,
> /usr/share/initrd-tools/scripts/e2fsprogs currently contains
> "LD_ASSUME_KERNEL=2.4". This needs to change to "LD_ASSUME_KERNEL=2.4.1"

Two questions....  first of all, this is a testing/unstable bug,
right?  I had a vague memory from a LCA 2006 presentation that we were
going to be desupporting the 2.4 kernel, or did I get that wrong?  Not
that this means we shouldn't fix the bug, but I'm wondering whether
this should really be considered an RC bug or not; how many people are
still using a 2.4 kernel on testing/unstable, and is that a supported
configuration.  I would have at thought this was at best an
"important" or "normal" bug.  The answer to this question would
basically affect whether or not I try to upload something right away,
or after I finish a few other changes currently on deck and can afford
to wait a few days.

Secondly, could you try this out since you obviously have a 2.4 system
handy?  What it does is avoid setting LD_ASSUME_KERNEL at all if the
script is currently running on a 2.4 kernel.  That should make the
script more robust, for someone who is purely running 2.4, and glibc
changes the minimum kernel version again.  It would only set
LD_ASSUME_KERNEL in the presumably rare case where you are running a
2.6 kernel, and for some reason want to install and run mkinitrd on a
2.4 kernel.  IIRC, that was the scenario that needed the
LD_ASSUME_KERNEL environment variable in the first place, so we might
as well restrict it to that.

Thanks, regards,

                                                - Ted

diff -r caa07aa7226d debian/initrd-tools.e2fsprogs
--- a/debian/initrd-tools.e2fsprogs     Sun Apr 23 12:43:40 2006 -0400
+++ b/debian/initrd-tools.e2fsprogs     Mon Apr 24 02:34:48 2006 -0400
@@ -9,8 +9,12 @@ cp /usr/lib/e2initrd_helper $INITRDDIR/b
 
 case "$VERSION" in
     2.4.*)
-       LD_ASSUME_KERNEL=2.4
-       export LD_ASSUME_KERNEL
+        case "uname -r" in
+           2.4.*)  :   ;;
+           *)  LD_ASSUME_KERNEL=2.4.1
+               export LD_ASSUME_KERNEL
+               ;;
+        esac
        ;;
 esac
 


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to