Package: shotdetect
Version: 1.0.86-5+b2
Severity: important
File: /usr/bin/shotdetect
Dear Maintainer,
This happened on Debian10. The same code used to work fine on Debian9.
* What led up to the situation?
A: I wanted to build the application from its "apt source" package.
* What exactly did you do (or not do) that was effective (or
ineffective)?
A: I've downloaded the package source (apt source shotdetect), then
ran `debuild -us -uc`, without any modifications to the source.
* What was the outcome of this action?
A: The generated shotdetect binary exits with an "invalid pointer"
error when initializing the output folder(names).
The binary provided by the official repositories works fine though.
* What outcome did you expect instead?
I expected the created binary to work just like the one from the
repositories.
**The good news is, it's fixed :) **
In fact it's a missing "return" statement in "create_img_dir()" in
src/image.cpp.
Thanks to Georg Lippitsch and Giulio Paci for finding it :)
I've tested the fix and can provide a patch.
Here's the output of "quilt diff" after the fix:
---------------------
Index: shotdetect-1.0.86/src/image.cpp
===================================================================
--- shotdetect-1.0.86.orig/src/image.cpp
+++ shotdetect-1.0.86/src/image.cpp
@@ -66,6 +66,7 @@ image::create_img_dir ()
}
free (buf);
+ return 0;
}
int
---------------------
Thanks in advance,
Peter B.
