Control: tag -1 - confirmed + moreinfo

Hi Gianfranco,

now that Bullseye is released and I'm preparing the upload of a new
upstream release, I've revisited this bug report.

Gianfranco Costamagna wrote:
> > Yeah, and the version.sh call itself can be removed, too. Will do.

Planned to do that(*), but …

> Unfortunately, it became a little difficult to implement, due to the 
> version.sh file
> not being easy to convert into a "sed s/FOO/foo/g < dkms.in > dkms"
> 
> This is what I did before thinking it was not easily upstreamable:

… now you've lost me complete.

Was that meant as patch to apply to the package? Or was it just a
historical digression?

If this was meant as to be included, I assume that file name was still
preliminary:

> --- iptables-netflow-2.5/debian/patches/patch 1970-01-01 01:00:00.000000000 
> +0100
> +++ iptables-netflow-2.5/debian/patches/patch 2020-08-11 21:00:13.000000000 
> +0200

And the entry in debian/patches/series seems missing, too.

> Feel free to send it upstream if you like it!

Admittedly it looks more complicated than necessary. And despite
having reread the whole bug report at least twice, I'm no more seeing
the motivation for this, also because dkms itself has been fixed by
you.

Actually I'm not even seeing the motivation to remove that
popd/pushd/version.sh part anymore. Sorry.

                Regards, Axel
-- 
 ,''`.  |  Axel Beckert <a...@debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

Reply via email to