Package: release.debian.org Severity: normal Tags: bullseye User: release.debian....@packages.debian.org Usertags: pu X-Debbugs-Cc: ssg...@debian.org
[ Reason ] Themes were inadvertently not built into the termshark package, causing the UI to fail to render. This was reported upstream at https://github.com/gcla/termshark/issues/114, then reported to Debian in #992831. This is a regression, and also makes the package generally unusable. [ Impact ] If this update isn't approved the user will have to follow the workaround provided by the author at https://github.com/gcla/termshark/issues/114#issuecomment-904273172 While not a deal-breaker it requires a non-zero amount of effort by the end user. [ Tests ] Due to the nature of the bug (display issue) it is hard to test using automated tests (which, of course, is how it was missed). Realistically the best way to test it is by running the termshark command after installing the package. [ Risks ] The only change is to the build flags, so I feel the risk is low. [ Checklist ] [x] *all* changes are documented in the d/changelog [x] I reviewed all changes and I approve them [x] attach debdiff against the package in stable [x] the issue is verified as fixed in unstable [ Changes ] The only change is including the "assets/themes" directory in the build process. [ Other info ] This is fixed in 2.2.0-2 which has been uploaded to unstable.
diff -Nru termshark-2.2.0/debian/changelog termshark-2.2.0/debian/changelog --- termshark-2.2.0/debian/changelog 2021-01-10 03:44:34.000000000 -0600 +++ termshark-2.2.0/debian/changelog 2021-08-23 22:55:12.000000000 -0500 @@ -1,3 +1,10 @@ +termshark (2.2.0-1+deb11u1) bullseye; urgency=medium + + * Team upload + * Include themes in package (Closes: #992831) + + -- Stephen Gelman <ssg...@debian.org> Mon, 23 Aug 2021 22:55:12 -0500 + termshark (2.2.0-1) unstable; urgency=medium * Team upload diff -Nru termshark-2.2.0/debian/rules termshark-2.2.0/debian/rules --- termshark-2.2.0/debian/rules 2021-01-10 03:44:34.000000000 -0600 +++ termshark-2.2.0/debian/rules 2021-08-23 22:54:41.000000000 -0500 @@ -1,6 +1,7 @@ #!/usr/bin/make -f export DH_GOLANG_GO_GENERATE := 1 +export DH_GOLANG_INSTALL_EXTRA := assets/themes include /usr/share/dpkg/pkg-info.mk