Hi Tony, Emmanuel, On Thu, Aug 12, 2021 at 5:09 AM tony mancill <tmanc...@debian.org> wrote: > > On Sun, Jul 04, 2021 at 10:17:22AM -0300, Emmanuel Arias wrote: > > Source: s2-geometry-library > > Version: 1.0.1-2 > > Severity: normal > > X-Debbugs-Cc: eam...@yaerobi.com > > > > Dear Maintainer, > > > > s2-geometry-library is pointing to [0] and that's wrong. The > > correct homepage should be [1]. > > > > [0] https://s2geometry.io/ > > [1] https://github.com/google/s2-geometry-library-java > > Hello Emmanuel, > > Thank you for the bug report. At the time the package was created, we > used the fork here [2], but there is very recent activity, including a > new release at the repo you suggest [1]. I will check with Sudip to be > sure, but I think we should probably update the debian/watch file to use > [1] as well.
Sorry, I got busy with my $dayjob and this one completely slipped out of my mind. We had a discussion about this issue or irc and I am copying from my logs. Jul 07 19:42:35 <sudip> pabs: s2-geometry-library should not have "https://github.com/google/s2-geometry-library-java"; as homepage. Its packaged from the fork which is at "https://github.com/io-sgr/s2-geometry-library-java";. Its mentioned at https://salsa.debian.org/java-team/s2-geometry-library/-/blob/master/debian/copyright#L3 Jul 07 20:13:11 <eamanu> sudip: so, should be https://salsa.debian.org/java-team/s2-geometry-library/-/blob/master/debian/copyright#L3? Jul 07 20:14:49 <sudip> sorry, did not understand Jul 07 20:15:02 <sudip> what should be? Jul 07 20:15:35 <eamanu> 'https://github.com/io-sgr/s2-geometry-library-java' Jul 07 20:15:39 <eamanu> isn't? Jul 07 20:16:42 <eamanu> ah no Jul 07 20:17:09 <eamanu> https://s2geometry.io/getS2.html here mention the Java library Jul 07 20:18:53 <sudip> yes, but that points to the google repo Jul 07 20:19:06 <sudip> and this one is a fork of that Jul 07 20:43:17 <eamanu> sudip: Oh, so if I understand ok, s2-geometry-library it's a fork of the google repo, so, IMO should homepage should point to the fork's homepage (in this case the GH repo) Jul 07 20:44:19 <sudip> eamanu: I am confused about that. Policy says "The URL of the web site for this package, preferably (when applicable) the site from which the original source can be obtained and any additional upstream documentation or information may be found". And that is the only url where additional info or doc are available. Jul 07 20:45:01 <sudip> thats why I mentioned the source link in s/copyright and gave this url in homepage. Jul 07 20:45:15 <sudip> d/copyright Jul 07 20:46:51 <eamanu> yes, but, being a fork, original repo and the fork, can be out o sync, and that will be a problem Jul 07 20:47:13 <eamanu> i guess that was the pabs observation Jul 07 20:48:36 <sudip> eamanu: yes, and its mentioned in d/control that its a fork Jul 07 20:49:58 <eamanu> https://salsa.debian.org/java-team/s2-geometry-library/-/blob/master/debian/control#L11 but this point to google repo Jul 07 20:51:05 <sudip> that points to the homepage where additional information and Developer Guide are available. Jul 08 01:35:03 <pabs> sudip: ack, personally I think the fork should be merged back upstream, since both are still developed and there are not many extra commits on the fork Jul 08 01:36:31 <pabs> "This branch is 6 commits ahead, 4 commits behind google:master." Jul 08 09:06:16 <sudip> pabs: yes. and when I packaged it "4 commits behind" was not there. The last update to the google repo at that time was in 2011 Jul 08 09:07:23 <sudip> I will raise an issue in both google repo and the fork repo requesting then to merge with eachother Jul 08 09:45:37 <pabs> sudip: the fork doesn't allow issues Jul 08 09:45:50 <pabs> so maybe send them an email? Jul 08 09:46:06 <pabs> google does seem to be very slow updating, there is an issue about the slowness Jul 08 09:46:47 <sudip> 10 years can be called as little slow :D Jul 08 09:47:03 <pabs> :) So, in summary, this one was packaged from the fork as it was assumed that the Google repo is dead, but then the fork diverged from the original Google repo as Google repo has suddenly merged something after 10 years. But again, https://s2geometry.io/ points to the original Google repo but contains a huge amount of documentation which is still relevant for this package. So, to capture all the information I decided to use "Homepage: https://s2geometry.io/"; at https://salsa.debian.org/java-team/s2-geometry-library/-/blob/master/debian/control#L11 and link of the source from where it was packaged at https://salsa.debian.org/java-team/s2-geometry-library/-/blob/master/debian/copyright#L3. -- Regards Sudip
