On Fri, 30 Jul 2021 22:31:07 +0200 Salvatore Bonaccorso <car...@debian.org>
wrote:
> [1]
> https://git.claws-mail.org/?p=claws.git;a=commit;h=ac286a71ed78429e16c612161251b9ea90ccd431
I'm not an expert, so feedback are welcome.
I think that [1] maybe incomplete.
[1] commit fixes two parts, checking by is_uri_string [2] and new comparison
with uri->uri. [3]
[2]
if (is_uri_string(uri->uri) == FALSE)
- return TRUE;
+ return FALSE;
It seems ok, if it is not valid string, it should return FALSE.
[3]
+ if (strlen(uri->uri) > get_uri_len(uri->uri))
+ retval = FALSE;
Before this check, there are "if (retval == FALSE)" block,
thus the above code must be put before "if (retval == FALSE)" block,
so this fix is wrong. (at least it doesn't work as expected)
Regards,
