Package: release.debian.org Severity: normal User: release.debian....@packages.debian.org Usertags: unblock
Hi RMs, I would like to ask for unblocking GraphicsMagick, with a simple but important fix of freeing used memory[1]. [ Reason ] Fixes a simple regression - writing labelled PDF files. [ Impact ] No more assertion on normal and common usage. [ Tests ] Good upstream test suite. [ Risks ] None. [ Checklist ] [x] all changes are documented in the d/changelog [x] I reviewed all changes and I approve them [x] attach debdiff against the package in testing unblock graphicsmagick/1.4+really1.3.36+hg16481-2 Thanks for considering, Laszlo/GCS [1] http://hg.graphicsmagick.org/hg/GraphicsMagick/rev/22aaff86b4aa
diff -Nru graphicsmagick-1.4+really1.3.36+hg16481/debian/changelog graphicsmagick-1.4+really1.3.36+hg16481/debian/changelog --- graphicsmagick-1.4+really1.3.36+hg16481/debian/changelog 2021-02-28 23:26:56.000000000 +0100 +++ graphicsmagick-1.4+really1.3.36+hg16481/debian/changelog 2021-07-24 11:42:42.000000000 +0200 @@ -1,3 +1,10 @@ +graphicsmagick (1.4+really1.3.36+hg16481-2) unstable; urgency=medium + + * Backport fix for use appropriate memory deallocator for memory returned + by StringToList() (closes: #991380). + + -- Laszlo Boszormenyi (GCS) <g...@debian.org> Sat, 24 Jul 2021 11:42:42 +0200 + graphicsmagick (1.4+really1.3.36+hg16481-1) unstable; urgency=high * Mercurial snapshot, fixing the following security issues: diff -Nru graphicsmagick-1.4+really1.3.36+hg16481/debian/patches/series graphicsmagick-1.4+really1.3.36+hg16481/debian/patches/series --- graphicsmagick-1.4+really1.3.36+hg16481/debian/patches/series 2020-06-03 17:49:58.000000000 +0200 +++ graphicsmagick-1.4+really1.3.36+hg16481/debian/patches/series 2021-07-24 11:42:42.000000000 +0200 @@ -1,2 +1,3 @@ link-demos.diff semaphore_O0_ppc64el.patch +use_appropriate_memory_deallocator.patch diff -Nru graphicsmagick-1.4+really1.3.36+hg16481/debian/patches/use_appropriate_memory_deallocator.patch graphicsmagick-1.4+really1.3.36+hg16481/debian/patches/use_appropriate_memory_deallocator.patch --- graphicsmagick-1.4+really1.3.36+hg16481/debian/patches/use_appropriate_memory_deallocator.patch 1970-01-01 01:00:00.000000000 +0100 +++ graphicsmagick-1.4+really1.3.36+hg16481/debian/patches/use_appropriate_memory_deallocator.patch 2021-07-24 11:42:42.000000000 +0200 @@ -0,0 +1,52 @@ + +# HG changeset patch +# User Bob Friesenhahn <bfrie...@graphicsmagick.org> +# Date 1626915582 18000 +# Node ID 22aaff86b4aa34c10b3fbfb104adaaeef8653a36 +# Parent acf305f9ef3e85e6273d62e72d81cce03440eb3d +WritePDFImage(): Use appropriate memory deallocator for memory returned by StringToList(). + +diff -r acf305f9ef3e -r 22aaff86b4aa ChangeLog +--- a/ChangeLog Wed Jul 21 19:47:33 2021 -0500 ++++ b/ChangeLog Wed Jul 21 19:59:42 2021 -0500 +@@ -1,3 +1,9 @@ ++2021-07-21 Bob Friesenhahn <bfrie...@simple.dallas.tx.us> ++ ++ * coders/pdf.c (WritePDFImage): Use appropriate memory deallocator ++ for memory returned by StringToList(). Fixes SourceForge issue ++ 646 "Assertion failed using -label with PDF". ++ + 2021-02-28 Bob Friesenhahn <bfrie...@simple.dallas.tx.us> + + * configure.ac: Add tests for Jasper jp2_decode(), jpc_decode(), +diff -r acf305f9ef3e -r 22aaff86b4aa coders/pdf.c +--- a/coders/pdf.c Wed Jul 21 19:47:33 2021 -0500 ++++ b/coders/pdf.c Wed Jul 21 19:59:42 2021 -0500 +@@ -1046,9 +1046,9 @@ + FormatString(buffer,"(%.1024s) Tj\n",labels[i]); + (void) WriteBlobString(image,buffer); + (void) WriteBlobString(image,"ET\n"); +- MagickFreeResourceLimitedMemory(labels[i]); ++ MagickFreeMemory(labels[i]); + } +- MagickFreeResourceLimitedMemory(labels); ++ MagickFreeMemory(labels); + } + FormatString(buffer,"%g 0 0 %g %ld %ld cm\n",x_scale,y_scale,geometry.x, + geometry.y); +diff -r acf305f9ef3e -r 22aaff86b4aa www/Changelog.html +--- a/www/Changelog.html Wed Jul 21 19:47:33 2021 -0500 ++++ b/www/Changelog.html Wed Jul 21 19:59:42 2021 -0500 +@@ -35,6 +35,12 @@ + <div class="document"> + + ++<p>2021-07-21 Bob Friesenhahn <<a class="reference external" href="mailto:bfriesen%40simple.dallas.tx.us">bfriesen<span>@</span>simple<span>.</span>dallas<span>.</span>tx<span>.</span>us</a>></p> ++<blockquote> ++<p>* coders/pdf.c (WritePDFImage): Use appropriate memory deallocator ++for memory returned by StringToList(). Fixes SourceForge issue ++646 "Assertion failed using -label with PDF".</p> ++</blockquote> + <p>2021-02-28 Bob Friesenhahn <<a class="reference external" href="mailto:bfriesen%40simple.dallas.tx.us">bfriesen<span>@</span>simple<span>.</span>dallas<span>.</span>tx<span>.</span>us</a>></p> + <blockquote> + <p>* configure.ac: Add tests for Jasper jp2_decode(), jpc_decode(),
