Control: severity -1 serious

On Sun, Jun 27, 2021 at 04:15:05AM +0900, Hideki Yamane wrote:
> control: severity -1 wishlist
> 
> Hi,
> 
> On Mon, 25 Jan 2021 19:14:08 +0000 =?utf-8?q?Ville_Skytt=C3=A4?= 
> <ville.sky...@iki.fi> wrote:
> > /etc/init.d/openipmi invokes /sbin/lsmod, but nothing in the package's
> > dependency chain pulls it in. I suppose adding dependency on kmod is
> > in order.
> 
>  As debian/openipmi.init
>  https://sources.debian.org/src/openipmi/2.0.29-0.1/debian/openipmi.init/
> 
> > unload_all_ipmi_modules()
> > {
> (snip)
> >         # delete interface node ONLY if ipmi_devintf is unloaded
> >         [ `lsmod | grep -c "ipmi_devintf"` -eq 0 ] &&
> >             rm -f "/dev/ipmi${INTF_NUM}"
> > }
> > 
> > unload_ipmi_modules_leave_features()
> > {
> >     for m in ${MODULES_INTERFACES}; do
> >             modprobe -q -r ${m} > /dev/null 2>&1
> >     done
> >         # delete interface node ONLY if ipmi_devintf is unloaded
> >         [ `lsmod | grep -c "ipmi_devintf"` -eq 0 ] &&
> >             rm -f "/dev/ipmi${INTF_NUM}"
> >     lsmod | egrep -q "ipmi_(poweroff|watchdog)" > /dev/null 2>&1
> >     if [ "$?" -ne "0" ]; then
> >             stop_watchdog_quiet
> >             stop_powercontrol_quiet
> >             for m in ${MODULES}; do
> >                     modprobe -q -r ${m} > /dev/null 2>&1
> >             done
> >     fi
> > }
> 
>  It seems that the lack of lsmod does not prevent openipmi to work,
>  so just add "Recommends: kmod" is enough, IMHO.
> 
>  And it is NOT "serious" problem since it works without kmod except
>  two functions and the average environment have kmod package, so
>  severity: wishlist is better.
>...

How did you test that it does actually works?

It failed for me when I tried before raising the severity:

Starting LSB: OpenIPMI Driver init script...
Starting ipmi drivers ipmi/etc/init.d/openipmi: line 115: /sbin/lsmod: No such 
file or directory
/etc/init.d/openipmi: line 115: /sbin/lsmod: No such file or directory
 failed!
.
openipmi.service: Control process exited, code=exited, status=1/FAILURE
openipmi.service: Failed with result 'exit-code'.
Failed to start LSB: OpenIPMI Driver init script.

> Regards,

cu
Adrian

Reply via email to