On 2021-03-08, Chris Lamb wrote: > Whilst working on the Reproducible Builds effort [0] we noticed that > php8.0 could not be built reproducibly. > > Patch attached to make the build-defs.h, /usr/bin/php-config8.0 and > test-results.txt.gz reproducible.
The test-results.txt.gz also embeds the hostname, kernel version, build time, etc. ... https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/php8.0.html Some of these things may be sanitized usefully (although perhaps a bit of a whack-a-mole game over time), but if any sort of timing information is desired, sanitizing that data would defeat the purpose of the log. We had a similar discussion for binutils which does something similar: https://bugs.debian.org/950585 If the test suite output is not too huge, I think it might be better to not ship test-results.txt in the package, but to output the contents to the build log (so you could access the necessary test-results from buildd.debian.org). We may also need to explore finding a way for source packages to store things like test suite logs outside of the actual .deb packages, as for binutils it was not feasible to output the full test-suite log during the build for size constraints... FWIW, it looks like PHP 7.4 has the same issues, although I haven't checked if the patch applies without modification. live well, vagrant
signature.asc
Description: PGP signature
