Package: release.debian.org
Severity: normal
User: release.debian....@packages.debian.org
Usertags: unblock
Please unblock package php-horde-memcache
I am unsure if php-horde-memcache 2.1.1-7 will migrate just because
of succeeded autopktests, so filing an unblock bug anyway.
[ Reason ]
Upstream provided a PHP 8.0 compatibility fix. eople have started used
php 8.0 already on buster (from https://packages.sury.org/php/), more
will follow for bullseye, although php7.4 will be the default for
bullseye. So, fixing things for PHP 8.0 is probably nice to have if fixed
by a simple change.
[ Impact ]
php-horde-memcache won't be usable with php8.0.
[ Tests ]
Patch introspection. Not broken on php7.4, autopkgtests succeed.
[ Risks ]
Breakage of php-horde in Debian where php-horde-memcache is in use.
[ Checklist ]
[x] all changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in testing
[ Other info ]
None.
unblock php-horde-memcache/2.1.1-7
diff -Nru php-horde-memcache-2.1.1/debian/changelog
php-horde-memcache-2.1.1/debian/changelog
--- php-horde-memcache-2.1.1/debian/changelog 2020-07-01 13:48:57.000000000
+0200
+++ php-horde-memcache-2.1.1/debian/changelog 2021-07-05 14:14:04.000000000
+0200
@@ -1,3 +1,10 @@
+php-horde-memcache (2.1.1-7) unstable; urgency=medium
+
+ * d/patches: Add 0001_Reorder-glue-and-array-parameters.patch. Reorder glue
+ and array parameters in implode(). Prepare for PHP 8.x.
+
+ -- Mike Gabriel <sunwea...@debian.org> Mon, 05 Jul 2021 14:14:04 +0200
+
php-horde-memcache (2.1.1-6) unstable; urgency=medium
* d/control: Add to Uploaders: Juri Grabowski.
diff -Nru
php-horde-memcache-2.1.1/debian/patches/0001_Reorder-glue-and-array-parameters.patch
php-horde-memcache-2.1.1/debian/patches/0001_Reorder-glue-and-array-parameters.patch
---
php-horde-memcache-2.1.1/debian/patches/0001_Reorder-glue-and-array-parameters.patch
1970-01-01 01:00:00.000000000 +0100
+++
php-horde-memcache-2.1.1/debian/patches/0001_Reorder-glue-and-array-parameters.patch
2021-07-05 14:14:04.000000000 +0200
@@ -0,0 +1,28 @@
+From ffd585d3be551f6e1a5283779294f2cd241c4cd1 Mon Sep 17 00:00:00 2001
+From: Michael J Rubinsky <mrubi...@horde.org>
+Date: Mon, 31 May 2021 12:01:18 -0400
+Subject: [PATCH] Reorder glue and array parameters
+
+Deprecated since 7.4 and an error in 8.0
+
+Signed-off-by: Mike Gabriel <mike.gabr...@das-netzwerkteam.de>
+---
+ Horde_Memcache-2.1.1/lib/Horde/Memcache.php | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Horde_Memcache-2.1.1/lib/Horde/Memcache.php
b/Horde_Memcache-2.1.1/lib/Horde/Memcache.php
+index a13ca2c..498d88c 100644
+--- a/Horde_Memcache-2.1.1/lib/Horde/Memcache.php
++++ b/Horde_Memcache-2.1.1/lib/Horde/Memcache.php
+@@ -202,7 +202,7 @@ class Horde_Memcache implements Serializable
+
+ if (isset($this->_params['logger'])) {
+ $this->_logger = $this->_params['logger'];
+- $this->_logger->log('Connected to the following memcache
servers:' . implode($this->_servers, ', '), 'DEBUG');
++ $this->_logger->log('Connected to the following memcache
servers:' . implode(', ', $this->_servers), 'DEBUG');
+ }
+ }
+
+--
+2.30.2
+
diff -Nru php-horde-memcache-2.1.1/debian/patches/series
php-horde-memcache-2.1.1/debian/patches/series
--- php-horde-memcache-2.1.1/debian/patches/series 1970-01-01
01:00:00.000000000 +0100
+++ php-horde-memcache-2.1.1/debian/patches/series 2021-07-05
14:14:04.000000000 +0200
@@ -0,0 +1 @@
+0001_Reorder-glue-and-array-parameters.patch
