Source: crowdsec Source-Version: 1.0.9-2 Severity: important User: debian-d...@lists.debian.org Usertags: dpkg-db-access-ctrl
Hi! This package contains the «cscli» program, which directly accesses the dpkg internal database, which seems gratuitous. The postinst is overloaded to act as some kind of helper that is then called by Go code, or directly by the user (as prompted by the README). Neither of the two functions involved share any other code with the rest of the maintscript, and as it is this is not upstreamable. These should be split into an external helper that gets called by both the maintscript and the Go code. Or integrated directly in the Go CLI tool (but that would be a bit more work). This is a problem for several reasons, because even though the layout and format of the dpkg database is administrator friendly, and it is expected that those might need to mess with it, in case of emergency, this “interface” does not extend to other programs besides the dpkg suite of tools. The admindir can also be configured differently at dpkg build or run-time. And finally, the contents and its format, might change in the future. Thanks, Guillem
