Control: clone -1 -2 Control: reassign -2 puppet-module-puppetlabs-haproxy 2.1.0-2 Control: retitle -2 puppet-module-puppetlabs-haproxy: clean up update-alternatives handling Control: severity -2 important Control: tags -2 =
On 2021-05-28 23:49:40 +0200, Thomas Goirand wrote:
> Hi,
>
> Sorry, I missed your reply. Thanks for the ping.
>
> Sebastian must be right, but then that's a different issue than the one
> that I'm trying to fix. Maybe a bug (of IMO severity "important") should
> be filled against this package.
Done
Cheers
> Though then probably also against all
> other Puppet packages I maintain, which makes it a mass bug filling,
> which may not be appropriate. IMO it may be best to just fix this after
> the release.
>
> Also, there's currently no other puppet-module-*-haproxy available in
> Debian right now, so even if Sebastian, this has no consequence.
>
> Anyways, please still unblock this fix, which is IMO a way more annoying
> than just removing the alternatives on removal/disappear.
>
> Cheers,
>
> Thomas Goirand (zigo)
>
> On 5/27/21 9:26 PM, Paul Gevers wrote:
> > Hi Thomas,
> >
> > Ping.
> >
> > Paul
> > Note: without reply, we'll close the bug without action
> >
> > On 20-04-2021 11:03, Sebastian Ramacher wrote:
> >> Control: tags -1 moreinfo
> >>
> >> On 2021-04-17 12:02:44 +0200, Thomas Goirand wrote:
> >>> Package: release.debian.org
> >>> Severity: normal
> >>> User: release.debian....@packages.debian.org
> >>> Usertags: unblock
> >>>
> >>> Please unblock package puppet-module-puppetlabs-haproxy
> >>>
> >>> This fixes a minor issue in the prerm when removing
> >>> alternatives (ie: wrong path when removing the alternative).
> >>
> >> Why is update-alternatives run on upgrade and deconfigure in prerm? From
> >> update-alternatives' manpage:
> >>
> >> update-alternatives is usually called from the following Debian package
> >> maintainer scripts, postinst (configure) to install the alternative and
> >> from prerm and postrm (remove) to remove the alternative. Note: in most
> >> (if not all) cases no other maintainer script actions should call
> >> update-alternatives, in particular neither of upgrade nor disappear, as
> >> any other such action can lose the manual state of an alternative, or
> >> make the alternative temporarily flip-flop, or completely switch when
> >> several of them have the same priority.
> >>
> >>
> >> Cheers
> >>
> >>
> >>>
> >>> (very) small debdiff attached.
> >>>
> >>> Please unblock puppet-module-puppetlabs-haproxy/2.1.0-3.
> >>>
> >>> Cheers,
> >>>
> >>> Thomas Goirand (zigo)
> >>
> >>> diff -Nru puppet-module-puppetlabs-haproxy-2.1.0/debian/changelog
> >>> puppet-module-puppetlabs-haproxy-2.1.0/debian/changelog
> >>> --- puppet-module-puppetlabs-haproxy-2.1.0/debian/changelog
> >>> 2020-03-24
> > 11:21:33.000000000 +0100
> >>> +++ puppet-module-puppetlabs-haproxy-2.1.0/debian/changelog
> >>> 2021-04-17
> > 11:58:30.000000000 +0200
> >>> @@ -1,3 +1,9 @@
> >>> +puppet-module-puppetlabs-haproxy (2.1.0-3) unstable; urgency=medium
> >>> +
> >>> + * Fix update-alternatives --remove in prerm.
> >>> +
> >>> + -- Thomas Goirand <z...@debian.org> Sat, 17 Apr 2021 11:58:30 +0200
> >>> +
> >>> puppet-module-puppetlabs-haproxy (2.1.0-2) unstable; urgency=medium
> >>>
> >>> [ Ondřej Nový ]
> >>> diff -Nru
> >>> puppet-module-puppetlabs-haproxy-2.1.0/debian/puppet-module-puppetlabs-haproxy.prerm
> >>>
> >>> puppet-module-puppetlabs-haproxy-2.1.0/debian/puppet-module-puppetlabs-haproxy.prerm
> >>> ---
> >>> puppet-module-puppetlabs-haproxy-2.1.0/debian/puppet-module-puppetlabs-haproxy.prerm
> >>> 2020-03-24 11:21:33.000000000 +0100
> >>> +++
> >>> puppet-module-puppetlabs-haproxy-2.1.0/debian/puppet-module-puppetlabs-haproxy.prerm
> >>> 2021-04-17 11:58:30.000000000 +0200
> >>> @@ -3,7 +3,7 @@
> >>> set -e
> >>>
> >>> if [ "${1}" = "remove" ] || [ "${1}" = "upgrade" ] || [ "${1}" =
> > "deconfigure" ] ; then
> >>> - update-alternatives --remove puppet-module-haproxy
> >>> /usr/share/puppet/modules.available/puppet-module-puppetlabs-haproxy
> >>> + update-alternatives --remove puppet-module-haproxy
> >>> /usr/share/puppet/modules.available/puppetlabs-haproxy
> >>> fi
> >>>
> >>> #DEBHELPER#
> >>
> >>
> >
>
--
Sebastian Ramacher
signature.asc
Description: PGP signature
